Extract method refactoring leads to inconsistent code behavior.

[provide a description of the issue]

Environment

• Operating System: Windows11
• JDK version: 17
• Visual Studio Code version: 1.88
• Java extension version: 1.29

Steps to Reproduce:

1. select "return;"
2. click “Refacator-Extract to method”

public class OriginalClass {
public void foo() {
Object runnable= null;
Object[] disposeList= null;
for (int i=0; i < disposeList.length; i++) {
if (disposeList [i] == null) {
disposeList [i] = runnable;
// extract method
return;
}
}
}
}

refactoring result:

Reason: The extraction method does not contain a return statement. If inline refactoring is performed on the extraction method, the behavior of the statement before and after refactoring is inconsistent.

Expected behavior: Check for statements like return, provide a prompt before refactoring, and do not allow extraction method refactoring.

Riproduci il caso nell’estensione Java usando l’esempio OriginalClass fornito e le versioni indicate di VS Code e JDK. Traccia il punto di ingresso del refactoring Extract to method; il lavoro è completato quando il refactoring rileva l’istruzione return, richiede quanto appropriato e non consente un’estrazione non sicura.