Extract method refactoring leads to inconsistent code behavior.

[provide a description of the issue]

Environment

• Operating System: Windows11
• JDK version: 17
• Visual Studio Code version: 1.88
• Java extension version: 1.29

Steps to Reproduce:

1. select "return;"
2. click “Refacator-Extract to method”

public class OriginalClass {
public void foo() {
Object runnable= null;
Object[] disposeList= null;
for (int i=0; i < disposeList.length; i++) {
if (disposeList [i] == null) {
disposeList [i] = runnable;
// extract method
return;
}
}
}
}

refactoring result:

Reason: The extraction method does not contain a return statement. If inline refactoring is performed on the extraction method, the behavior of the statement before and after refactoring is inconsistent.

Expected behavior: Check for statements like return, provide a prompt before refactoring, and do not allow extraction method refactoring.

Reproduisez le cas dans l’extension Java en utilisant l’exemple OriginalClass fourni et les versions indiquées de VS Code et JDK. Suivez le point d’entrée de la refactorisation Extract to method ; le travail est terminé lorsque la refactorisation détecte l’instruction return, demande ce qui est nécessaire le cas échéant et n’autorise pas une extraction non sûre.