reactjs / reactjs/react.dev

Incorrect definition of single responsibility principle in docs

Open
#2,081 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
11.8k
Forks
7.9k
Avg merge
1d 11h
Merged PRs (30d)
11

Description

One such technique is the single responsibility principle, that is, a component should ideally only do one thing.

From Martin Fowlers book "Clean Architecture" below:

Of all the SOLID principles, the Single Responsibility Principle might be the least well understood. That's likely because it has a particularly inappropriate name. It is too easy for programmers to hear the name and then assume that it means everyone module should do just one thing.

Is this something you all are open to me updating?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No documentation file, page, test, or entry point is named. Start by locating the passage containing the quoted single responsibility principle definition, then compare it with the proposed clarification from Clean Architecture. Done means the relevant wording is updated and the documentation remains accurate and consistent.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.