Networking docs appear outdated: credentials: 'omit' works on RN 0.86
まだ誰も着手していません。
- 主要言語
- C++
- スター
- 127k
- フォーク
- 25.3k
- 平均マージ
- 1日 23時間
- マージ済み PR(30日)
- 4
説明
Summary
The Networking docs list credentials: 'omit' as currently not working with fetch:
https://reactnative.dev/docs/network#known-issues-with-fetch-and-cookie-based-authentication
On React Native 0.86, the built-in global fetch respects credentials: 'omit' in all cookie scenarios tested on both iOS and Android:
- existing cookies are not sent on direct requests;
- existing cookies are not sent after an automatically followed
302; Set-Cookiefrom a direct response is not persisted;Set-Cookiefrom a302response is neither sent to the redirected request nor persisted.
Equivalent credentials: 'include' controls all behave in the opposite way, confirming that the cookie store and test server are working.
The other documented limitation, redirect: 'manual', is outside the scope of this report.
Environment
react-nativepackage: 0.86.2- Native runtime reported by
Platform.constants.reactNativeVersion: 0.86.0 - Expo: 57.0.9, Expo Go
- iOS: 26.5 simulator
- Android: API 37 emulator
- Fetch implementation: React Native built-in global
fetchEXPO_PUBLIC_USE_RN_FETCH=1- confirmed
global fetch !== expo/fetch
Expo SDK 57 documents EXPO_PUBLIC_USE_RN_FETCH=1 as the switch that keeps React Native's built-in fetch as the global implementation:
https://docs.expo.dev/versions/v57.0.0/sdk/expo/#expofetch-api
Reproduction
The test server provides these endpoints:
/api/set-cookie— responds withSet-Cookie: session=abc123andtheme=dark;/api/cookies— returns the receivedCookieheader;/api/redirect-to-cookies—302to/api/cookies;/api/redirect-set-cookie— responds with both302andSet-Cookie, redirecting to/api/cookies;/api/clear-test-cookies— expires all cookies used by the test.
The relevant client checks are equivalent to:
// Existing cookies: direct requests and automatic 302 follow
await clearTestCookies();
await fetch(`${API}/api/set-cookie`, { credentials: 'include' });
assert((await readCookies('include')).cookieHeader ===
'session=abc123; theme=dark');
assert((await readCookies('omit')).cookieHeader === null);
assert((await fetchRedirect('include')).cookieHeader ===
'session=abc123; theme=dark');
assert((await fetchRedirect('omit')).cookieHeader === null);
// A direct Set-Cookie response must be ignored with omit
await clearTestCookies();
await fetch(`${API}/api/set-cookie?scenario=direct-omit-response`, {
credentials: 'omit',
});
assert((await readCookies('include')).cookieHeader === null);
// Control: the same operation with include persists the cookie
await clearTestCookies();
await fetch(`${API}/api/set-cookie?scenario=direct-include-response`, {
credentials: 'include',
});
assert((await readCookies('include')).cookieHeader ===
'direct_include_response=should_persist');
// Set-Cookie received on a 302 must also be ignored with omit
await clearTestCookies();
const redirectedOmit = await fetch(
`${API}/api/redirect-set-cookie?scenario=redirect-omit-response`,
{ credentials: 'omit' },
);
assert((await redirectedOmit.json()).cookieHeader === null);
assert((await readCookies('include')).cookieHeader === null);
// Control: include sends the new cookie on the redirected request and persists it
await clearTestCookies();
const redirectedInclude = await fetch(
`${API}/api/redirect-set-cookie?scenario=redirect-include-response`,
{ credentials: 'include' },
);
assert((await redirectedInclude.json()).cookieHeader ===
'redirect_include_response=should_persist');
assert((await readCookies('include')).cookieHeader ===
'redirect_include_response=should_persist');
Results
All 10/10 checks passed independently on each platform.
| Behavior | Expected include control |
Expected omit behavior |
iOS | Android |
|---|---|---|---|---|
| Existing cookies, direct request | sent | not sent | PASS | PASS |
Existing cookies, followed 302 |
sent | not sent | PASS | PASS |
Direct response Set-Cookie |
persisted | ignored | PASS | PASS |
302 response Set-Cookie on redirected request |
sent | not sent | PASS | PASS |
302 response Set-Cookie after the request |
persisted | ignored | PASS | PASS |
Implementation context
The current request path also appears to implement this behavior explicitly:
whatwg-fetchmapscredentials: 'omit'toxhr.withCredentials = false:
https://github.com/JakeChampion/fetch/blob/v3.6.20/fetch.js#L587-L591- Android replaces the request client's cookie jar with
CookieJar.NO_COOKIESwhenwithCredentialsis false:
https://github.com/facebook/react-native/blob/v0.86.0/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.kt#L367-L373 - iOS sets
HTTPShouldHandleCookiesfromwithCredentials:
https://github.com/facebook/react-native/blob/v0.86.0/packages/react-native/Libraries/Network/RCTNetworking.mm#L316-L324
The native withCredentials wiring landed in 2017 (iOS, Android); the current Known Issues text was added later in react-native-website#769 in 2019. This history alone does not establish which edge cases were broken in 2019, but the unconditional wording does not match the current tested behavior.
Related older reports describe omit failing rather than the documentation being stale: #12956 and #30885. Neither documents a current remaining failure mode.
Request
Please remove credentials: 'omit' from the list of unsupported options in the current / 0.86 Networking docs. If a specific remaining edge case is known, please narrow the warning to that platform, version, or scenario and link the corresponding report.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
レポートでリンクされている Networking ドキュメントのセクションから着手し、特に fetch と cookie ベースの認証に関する既知の問題の記述を確認してください。credentials: 'omit' に関する記述を、報告されている React Native 0.86 の挙動に合わせて更新し、redirect: 'manual' の制限はスコープ外のままにしてください。古い警告が削除されるか、適切に限定されれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- react-native
- 領域
- documentation
- issue の種類
- ドキュメント
- 難易度
- 1/5
- 見積もり時間
- 1〜3時間
- 活発さ
- 静か
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 78/100