react / react/react-native

Networking docs appear outdated: credentials: 'omit' works on RN 0.86

Ouverte Adaptée aux débutants
#57,786 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub

Personne n'a encore pris cette issue.

Needs: Attention Needs: Repro
Langage dominant
C++
Étoiles
127k
Forks
25.3k
Merge moyen
1 j 23 h
PR mergées (30 j)
4

Description

Summary

The Networking docs list credentials: 'omit' as currently not working with fetch:

https://reactnative.dev/docs/network#known-issues-with-fetch-and-cookie-based-authentication

On React Native 0.86, the built-in global fetch respects credentials: 'omit' in all cookie scenarios tested on both iOS and Android:

  • existing cookies are not sent on direct requests;
  • existing cookies are not sent after an automatically followed 302;
  • Set-Cookie from a direct response is not persisted;
  • Set-Cookie from a 302 response is neither sent to the redirected request nor persisted.

Equivalent credentials: 'include' controls all behave in the opposite way, confirming that the cookie store and test server are working.

The other documented limitation, redirect: 'manual', is outside the scope of this report.

Environment

  • react-native package: 0.86.2
  • Native runtime reported by Platform.constants.reactNativeVersion: 0.86.0
  • Expo: 57.0.9, Expo Go
  • iOS: 26.5 simulator
  • Android: API 37 emulator
  • Fetch implementation: React Native built-in global fetch
    • EXPO_PUBLIC_USE_RN_FETCH=1
    • confirmed global fetch !== expo/fetch

Expo SDK 57 documents EXPO_PUBLIC_USE_RN_FETCH=1 as the switch that keeps React Native's built-in fetch as the global implementation:

https://docs.expo.dev/versions/v57.0.0/sdk/expo/#expofetch-api

Reproduction

The test server provides these endpoints:

  • /api/set-cookie — responds with Set-Cookie: session=abc123 and theme=dark;
  • /api/cookies — returns the received Cookie header;
  • /api/redirect-to-cookies302 to /api/cookies;
  • /api/redirect-set-cookie — responds with both 302 and Set-Cookie, redirecting to /api/cookies;
  • /api/clear-test-cookies — expires all cookies used by the test.

The relevant client checks are equivalent to:

// Existing cookies: direct requests and automatic 302 follow
await clearTestCookies();
await fetch(`${API}/api/set-cookie`, { credentials: 'include' });

assert((await readCookies('include')).cookieHeader ===
  'session=abc123; theme=dark');
assert((await readCookies('omit')).cookieHeader === null);

assert((await fetchRedirect('include')).cookieHeader ===
  'session=abc123; theme=dark');
assert((await fetchRedirect('omit')).cookieHeader === null);

// A direct Set-Cookie response must be ignored with omit
await clearTestCookies();
await fetch(`${API}/api/set-cookie?scenario=direct-omit-response`, {
  credentials: 'omit',
});
assert((await readCookies('include')).cookieHeader === null);

// Control: the same operation with include persists the cookie
await clearTestCookies();
await fetch(`${API}/api/set-cookie?scenario=direct-include-response`, {
  credentials: 'include',
});
assert((await readCookies('include')).cookieHeader ===
  'direct_include_response=should_persist');

// Set-Cookie received on a 302 must also be ignored with omit
await clearTestCookies();
const redirectedOmit = await fetch(
  `${API}/api/redirect-set-cookie?scenario=redirect-omit-response`,
  { credentials: 'omit' },
);
assert((await redirectedOmit.json()).cookieHeader === null);
assert((await readCookies('include')).cookieHeader === null);

// Control: include sends the new cookie on the redirected request and persists it
await clearTestCookies();
const redirectedInclude = await fetch(
  `${API}/api/redirect-set-cookie?scenario=redirect-include-response`,
  { credentials: 'include' },
);
assert((await redirectedInclude.json()).cookieHeader ===
  'redirect_include_response=should_persist');
assert((await readCookies('include')).cookieHeader ===
  'redirect_include_response=should_persist');

Results

All 10/10 checks passed independently on each platform.

Behavior Expected include control Expected omit behavior iOS Android
Existing cookies, direct request sent not sent PASS PASS
Existing cookies, followed 302 sent not sent PASS PASS
Direct response Set-Cookie persisted ignored PASS PASS
302 response Set-Cookie on redirected request sent not sent PASS PASS
302 response Set-Cookie after the request persisted ignored PASS PASS

Implementation context

The current request path also appears to implement this behavior explicitly:

The native withCredentials wiring landed in 2017 (iOS, Android); the current Known Issues text was added later in react-native-website#769 in 2019. This history alone does not establish which edge cases were broken in 2019, but the unconditional wording does not match the current tested behavior.

Related older reports describe omit failing rather than the documentation being stale: #12956 and #30885. Neither documents a current remaining failure mode.

Request

Please remove credentials: 'omit' from the list of unsupported options in the current / 0.86 Networking docs. If a specific remaining edge case is known, please narrow the warning to that platform, version, or scenario and link the corresponding report.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Piste de recherche

Commencez par la section de la documentation Networking liée dans le rapport, en particulier par le texte consacré aux problèmes connus de fetch et à l’authentification basée sur les cookies. Mettez à jour l’énoncé concernant les identifiants : « omit » afin qu’il corresponde au comportement signalé de React Native 0.86, tout en laissant la limitation redirect: 'manual' hors périmètre ; le travail est considéré comme terminé lorsque l’avertissement obsolète a été supprimé ou correctement restreint.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
react-native
Domaine
documentation
Type d'issue
Documentation
Difficulté
1/5
Temps estimé
1-3 heures
Activité
Calme
Clarté
Clairement spécifiée
Accessibilité débutants
78/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.