[Android][New Arch][Pressable] the `locationY` and `locationX` on Android are inconsistent
Chưa có ai nhận issue này.
- Ngôn ngữ chính
- C++
- Star
- 127k
- Fork
- 25.3k
- Merge trung bình
- 1 ngày 23 giờ
- Pull request đã merge (30 ngày)
- 4
Mô tả
Description
To make a separate issue of:
https://github.com/facebook/react-native/issues/36710#issuecomment-3204826621
It's been like 1 year there is many issues reported on Android about onPress not fired (in issues of this repo and by a lot of end-user).
Since I cannot reproduce because a lot of this issue are "random", I was looking for an alternative with an onPressOut workaround.
Was able to implement a full working workaround on iOS (scroll management, hitslop, ...) but when switching to Android everything was broke. My solution was based on locationY and locationX but after investigation, I noticed that the value of locationY and locationX on Android is not correct.
For exemple, when the onPressOut is triggered because the touch goes out of the screen, the locationY is equal to pageY.
When the onPressOut is trigger after the touch leave the Pressable, but still on another Pressable (stacked Button for exemple). The locationY looks like it's the value inside the second Pressable (expected 80, but received 15 for exemple).
Impact Touchables (WithoutFeedBack, Opacity, ...).
I don't know if it's the root-cause of all onPress issue, but might not help to handle it correctly.
In the code, found out that there is a "Legacy" / "non-legacy" logic that might explain why it's only on new-arch.
Regards
Steps to reproduce
- Create two Pressable with
onPressOut, log thelocationXandlocationY - Start pressing the first Pressable the slide quickly to the second one.
- The
onPressOutof the first one is triggered but display invalid valuelocationX/Y(supposed to be the calculated values of the second Pressable).
React Native Version
0.80.2
Affected Platforms
Runtime - Android
Output of npx @react-native-community/cli info
System:
OS: macOS 15.6
CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
Memory: 13.99 GB / 64.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 22.16.0
path: ~/.nvm/versions/node/v22.16.0/bin/node
Yarn:
version: 1.22.17
path: ~/.yarn/bin/yarn
npm:
version: 11.5.1
path: ~/.nvm/versions/node/v22.16.0/bin/npm
Watchman:
version: 2025.07.14.00
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.16.2
path: /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.5
- iOS 18.5
- macOS 15.5
- tvOS 18.5
- visionOS 2.5
- watchOS 11.5
Android SDK: Not Found
IDEs:
Android Studio: 2025.1 AI-251.26094.121.2512.13930704
Xcode:
version: 16.4/16F6
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.1
path: /usr/local/opt/bin/javac
Ruby:
version: 3.4.5
path: /usr/local/opt/ruby/bin/ruby
npmPackages:
"@react-native-community/cli":
installed: 19.1.1
wanted: ^19.1.0
react:
installed: 19.1.0
wanted: 19.1.0
react-native:
installed: 0.80.2
wanted: ^0.80.1
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
Stacktrace or Logs
See console.log of reproducer / video
MANDATORY Reproducer
https://github.com/Dallas62/rn-pressabe-issue-location
Screenshots and Videos
https://github.com/user-attachments/assets/5c6ba929-e44a-440c-909e-7b41c893c347
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Hướng nghiên cứu
Bắt đầu với ReactAndroid/src/main/java/com/facebook/react/uimanager/events/TouchesHelper.kt quanh dòng được tham chiếu và chạy reproducer bắt buộc rn-pressabe-issue-location trên Android với new architecture được bật. So sánh locationX và locationY từ onPressOut của Pressable đầu tiên trong khi di chuyển vào Pressable thứ hai hoặc ra ngoài màn hình; được xem là hoàn tất khi các tọa độ được báo cáo khớp với các giá trị mong đợi của Pressable bị ảnh hưởng.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- android, kotlin, react-native
- Lĩnh vực
- mobile
- Loại issue
- Lỗi
- Độ khó
- 4/5
- Thời gian dự kiến
- 3-5 ngày
- Mức độ hoạt động
- Ít trao đổi
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 52/100