react / react/react-native

[Android][New Arch][Pressable] the `locationY` and `locationX` on Android are inconsistent

Abierto
#53,366 8 comentarios 1 reacción 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Needs: Triage :mag: Platform: Android
Lenguaje dominante
C++
Estrellas
127k
Forks
25.3k
Merge medio
1 d 23 h
PR fusionados (30 d)
4

Descripción

Description

To make a separate issue of:
https://github.com/facebook/react-native/issues/36710#issuecomment-3204826621

It's been like 1 year there is many issues reported on Android about onPress not fired (in issues of this repo and by a lot of end-user).
Since I cannot reproduce because a lot of this issue are "random", I was looking for an alternative with an onPressOut workaround.
Was able to implement a full working workaround on iOS (scroll management, hitslop, ...) but when switching to Android everything was broke. My solution was based on locationY and locationX but after investigation, I noticed that the value of locationY and locationX on Android is not correct.

For exemple, when the onPressOut is triggered because the touch goes out of the screen, the locationY is equal to pageY.
When the onPressOut is trigger after the touch leave the Pressable, but still on another Pressable (stacked Button for exemple). The locationY looks like it's the value inside the second Pressable (expected 80, but received 15 for exemple).

Impact Touchables (WithoutFeedBack, Opacity, ...).

I don't know if it's the root-cause of all onPress issue, but might not help to handle it correctly.

In the code, found out that there is a "Legacy" / "non-legacy" logic that might explain why it's only on new-arch.

https://github.com/facebook/react-native/blob/d1a1020a4ab2f9bc5075598465b61fd83a45abd0/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/events/TouchesHelper.kt#L113

Regards

Steps to reproduce
  1. Create two Pressable with onPressOut, log the locationX and locationY
  2. Start pressing the first Pressable the slide quickly to the second one.
  3. The onPressOut of the first one is triggered but display invalid value locationX/Y (supposed to be the calculated values of the second Pressable).
React Native Version

0.80.2

Affected Platforms

Runtime - Android

Output of npx @react-native-community/cli info
System:
  OS: macOS 15.6
  CPU: (16) x64 Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz
  Memory: 13.99 GB / 64.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 22.16.0
    path: ~/.nvm/versions/node/v22.16.0/bin/node
  Yarn:
    version: 1.22.17
    path: ~/.yarn/bin/yarn
  npm:
    version: 11.5.1
    path: ~/.nvm/versions/node/v22.16.0/bin/npm
  Watchman:
    version: 2025.07.14.00
    path: /usr/local/bin/watchman
Managers:
  CocoaPods:
    version: 1.16.2
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.5
      - iOS 18.5
      - macOS 15.5
      - tvOS 18.5
      - visionOS 2.5
      - watchOS 11.5
  Android SDK: Not Found
IDEs:
  Android Studio: 2025.1 AI-251.26094.121.2512.13930704
  Xcode:
    version: 16.4/16F6
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.1
    path: /usr/local/opt/bin/javac
  Ruby:
    version: 3.4.5
    path: /usr/local/opt/ruby/bin/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 19.1.1
    wanted: ^19.1.0
  react:
    installed: 19.1.0
    wanted: 19.1.0
  react-native:
    installed: 0.80.2
    wanted: ^0.80.1
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: true
  newArchEnabled: true
Stacktrace or Logs
See console.log of reproducer / video
MANDATORY Reproducer

https://github.com/Dallas62/rn-pressabe-issue-location

Screenshots and Videos

https://github.com/user-attachments/assets/5c6ba929-e44a-440c-909e-7b41c893c347

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con ReactAndroid/src/main/java/com/facebook/react/uimanager/events/TouchesHelper.kt cerca de la línea referenciada y ejecuta el reproductor obligatorio rn-pressabe-issue-location en Android con la nueva arquitectura habilitada. Compara locationX y locationY del onPressOut del primer Pressable mientras te mueves hacia el segundo o fuera de la pantalla; se considera terminado cuando las coordenadas reportadas coinciden con los valores esperados del Pressable afectado.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
android, kotlin, react-native
Área
mobile
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
52/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.