react / react/react-native

Android ReactActivity Destroy Prevents Successful OnActivityResult Calls

Đang mở
#52,114 6 bình luận 0 reaction 0 người được giao Xem trên GitHub

Chưa có ai nhận issue này.

Help Wanted :octocat: Issue: Author Provided Repro Platform: Android
Ngôn ngữ chính
C++
Star
127k
Fork
25.3k
Merge trung bình
1 ngày 23 giờ
Pull request đã merge (30 ngày)
4

Mô tả

Description

If a native module opens an activity that redirects out of the application and the application is killed in the background by the Android OS, the react context is lost and the native module's activity is unable to call onActivityResult.

If the redirect from the third party app is back to the activity in the native module, the ReactActivity is not created at this point. When the native activity then sets result and finishes to return back to the ReactActivity the ReactActivity has to start up.

Originally reported: https://github.com/facebook/react-native/issues/30277

Steps to reproduce

Building the App

cd ReproducerApp
npm install
npm start
npm run android

Reproduction Steps

  1. Run the app on an Android device
  2. Tap the "Open Activity" button
  3. In the second activity, tap "Go to Web" to open Google in a browser
  4. Use the following command to forcibly kill the app:
    adb shell am kill com.reproducerapp
    
  5. Resume the activity with:
    adb shell am start -n com.reproducerapp/.RedirectActivity -d "redirect://crash"
    
  6. Tap "Return Result" in the activity
  7. Check logcat for missing "RESULT" and "Completed" logs
Expected Behavior

When returning to the app after it's been killed, the callback should work and you should see "RESULT" and "Completed" in the logs.

Actual Behavior

When the app is killed and then restored, the activity result is processed before React Native is ready. The JavaScript callback is not executed, and you won't see "RESULT" or "Completed" logs, indicating the callback was lost.

React Native Version

0.79.2

Affected Platforms

Runtime - Android

Output of npx @react-native-community/cli info
System:
  OS: macOS 15.5
  CPU: (10) arm64 Apple M1 Max
  Memory: 268.70 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.20.8
    path: ~/.nvm/versions/node/v18.20.8/bin/node
  Yarn:
    version: 1.22.19
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.9.2
    path: ~/.nvm/versions/node/v18.20.8/bin/npm
  Watchman:
    version: 2025.04.28.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods: Not Found
SDKs:
  iOS SDK: Not Found
  Android SDK:
    API Levels:
      - "30"
      - "31"
      - "32"
      - "33"
      - "33"
      - "34"
      - "35"
    Build Tools:
      - 28.0.3
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 33.0.1
      - 34.0.0
      - 34.0.0
      - 35.0.0
      - 35.0.0
      - 36.0.0
    System Images:
      - android-26 | Google APIs ARM 64 v8a
      - android-27 | ARM 64 v8a
      - android-27 | Google Play Intel x86 Atom
      - android-28 | ARM 64 v8a
      - android-28 | Google APIs ARM 64 v8a
      - android-28 | Google ARM64-V8a Play ARM 64 v8a
      - android-29 | Google APIs ARM 64 v8a
      - android-29 | Google Play ARM 64 v8a
      - android-30 | Google Play ARM 64 v8a
      - android-31 | Google Play ARM 64 v8a
      - android-33 | Google APIs ARM 64 v8a
      - android-34 | Google Play ARM 64 v8a
      - android-35 | Google APIs ARM 64 v8a
      - android-35 | Google Play ARM 64 v8a
      - android-UpsideDownCake | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2024.3 AI-243.24978.46.2431.13363775
  Xcode:
    version: /undefined
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.8
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 18.0.0
    wanted: 18.0.0
  react:
    installed: 19.0.0
    wanted: 19.0.0
  react-native:
    installed: 0.79.2
    wanted: 0.79.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: false

info React Native v0.80.0 is now available (your project is running on v0.79.2).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.80.0
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.79.2&to=0.80.0
info For more info, check out "https://reactnative.dev/docs/upgrading?os=macos".
Stacktrace or Logs
unknown:ReactHost com.reproducerapp E  Unhandled SoftException (Ask Gemini)
                                        com.facebook.react.bridge.ReactNoCrashSoftException: raiseSoftException(onActivityResult(activity = "com.reproducerapp.MainActivity@1afbd28", requestCode = "100", resultCode = "-1", data = "Intent { (has extras) }")): Tried to access onActivityResult while context is not ready
                                        	at com.facebook.react.runtime.ReactHostImpl.raiseSoftException(ReactHostImpl.java:1025)
                                        	at com.facebook.react.runtime.ReactHostImpl.raiseSoftException(ReactHostImpl.java:1018)
                                        	at com.facebook.react.runtime.ReactHostImpl.onActivityResult(ReactHostImpl.java:776)
                                        	at com.facebook.react.ReactDelegate.onActivityResult(ReactDelegate.java:187)
                                        	at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:192)
                                        	at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:79)
                                        	at android.app.Activity.onActivityResult(Activity.java:7571)
                                        	at android.app.Activity.internalDispatchActivityResult(Activity.java:9470)
                                        	at android.app.Activity.dispatchActivityResult(Activity.java:9447)
                                        	at android.app.ActivityThread.deliverResults(ActivityThread.java:6025)
                                        	at android.app.ActivityThread.performResumeActivity(ActivityThread.java:5454)
                                        	at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:5500)
                                        	at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:73)
                                        	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:63)
                                        	at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:169)
                                        	at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:101)
                                        	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
                                        	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2773)
                                        	at android.os.Handler.dispatchMessage(Handler.java:109)
                                        	at android.os.Looper.loopOnce(Looper.java:232)
                                        	at android.os.Looper.loop(Looper.java:317)
                                        	at android.app.ActivityThread.main(ActivityThread.java:8934)
                                        	at java.lang.reflect.Method.invoke(Native Method)
                                        	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
                                        	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)
MANDATORY Reproducer

https://github.com/melissaosullivan/rn-activity-destroy-state-lost-repro/tree/main

Screenshots and Videos

No response

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Hướng nghiên cứu

Tái hiện vòng đời được mô tả bằng các lệnh bắt buộc của ReproducerApp, sau đó lần theo stack từ ReactActivity.onActivityResult qua ReactActivityDelegate, ReactDelegate và ReactHostImpl.onActivityResult. Xác nhận rằng kết quả được gửi đến trước khi React context sẵn sàng và rằng flow đã hoàn tất tạo ra các log RESULT và Completed còn thiếu.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Đánh giá

Công nghệ
android, java
Lĩnh vực
mobile-dev
Loại issue
Lỗi
Độ khó
4/5
Thời gian dự kiến
3-5 ngày
Mức độ hoạt động
Đình trệ
Độ rõ ràng
Cần làm rõ
Mức phù hợp với người mới
35/100

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.