react / react/react-native

Android ReactActivity Destroy Prevents Successful OnActivityResult Calls

オープン
#52,114 コメント 6 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

Help Wanted :octocat: Issue: Author Provided Repro Platform: Android
主要言語
C++
スター
127k
フォーク
25.3k
平均マージ
1日 23時間
マージ済み PR(30日)
4

説明

Description

If a native module opens an activity that redirects out of the application and the application is killed in the background by the Android OS, the react context is lost and the native module's activity is unable to call onActivityResult.

If the redirect from the third party app is back to the activity in the native module, the ReactActivity is not created at this point. When the native activity then sets result and finishes to return back to the ReactActivity the ReactActivity has to start up.

Originally reported: https://github.com/facebook/react-native/issues/30277

Steps to reproduce

Building the App

cd ReproducerApp
npm install
npm start
npm run android

Reproduction Steps

  1. Run the app on an Android device
  2. Tap the "Open Activity" button
  3. In the second activity, tap "Go to Web" to open Google in a browser
  4. Use the following command to forcibly kill the app:
    adb shell am kill com.reproducerapp
    
  5. Resume the activity with:
    adb shell am start -n com.reproducerapp/.RedirectActivity -d "redirect://crash"
    
  6. Tap "Return Result" in the activity
  7. Check logcat for missing "RESULT" and "Completed" logs
Expected Behavior

When returning to the app after it's been killed, the callback should work and you should see "RESULT" and "Completed" in the logs.

Actual Behavior

When the app is killed and then restored, the activity result is processed before React Native is ready. The JavaScript callback is not executed, and you won't see "RESULT" or "Completed" logs, indicating the callback was lost.

React Native Version

0.79.2

Affected Platforms

Runtime - Android

Output of npx @react-native-community/cli info
System:
  OS: macOS 15.5
  CPU: (10) arm64 Apple M1 Max
  Memory: 268.70 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.20.8
    path: ~/.nvm/versions/node/v18.20.8/bin/node
  Yarn:
    version: 1.22.19
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.9.2
    path: ~/.nvm/versions/node/v18.20.8/bin/npm
  Watchman:
    version: 2025.04.28.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods: Not Found
SDKs:
  iOS SDK: Not Found
  Android SDK:
    API Levels:
      - "30"
      - "31"
      - "32"
      - "33"
      - "33"
      - "34"
      - "35"
    Build Tools:
      - 28.0.3
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 33.0.1
      - 34.0.0
      - 34.0.0
      - 35.0.0
      - 35.0.0
      - 36.0.0
    System Images:
      - android-26 | Google APIs ARM 64 v8a
      - android-27 | ARM 64 v8a
      - android-27 | Google Play Intel x86 Atom
      - android-28 | ARM 64 v8a
      - android-28 | Google APIs ARM 64 v8a
      - android-28 | Google ARM64-V8a Play ARM 64 v8a
      - android-29 | Google APIs ARM 64 v8a
      - android-29 | Google Play ARM 64 v8a
      - android-30 | Google Play ARM 64 v8a
      - android-31 | Google Play ARM 64 v8a
      - android-33 | Google APIs ARM 64 v8a
      - android-34 | Google Play ARM 64 v8a
      - android-35 | Google APIs ARM 64 v8a
      - android-35 | Google Play ARM 64 v8a
      - android-UpsideDownCake | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2024.3 AI-243.24978.46.2431.13363775
  Xcode:
    version: /undefined
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.8
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli":
    installed: 18.0.0
    wanted: 18.0.0
  react:
    installed: 19.0.0
    wanted: 19.0.0
  react-native:
    installed: 0.79.2
    wanted: 0.79.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: true
iOS:
  hermesEnabled: Not found
  newArchEnabled: false

info React Native v0.80.0 is now available (your project is running on v0.79.2).
info Changelog: https://github.com/facebook/react-native/releases/tag/v0.80.0
info Diff: https://react-native-community.github.io/upgrade-helper/?from=0.79.2&to=0.80.0
info For more info, check out "https://reactnative.dev/docs/upgrading?os=macos".
Stacktrace or Logs
unknown:ReactHost com.reproducerapp E  Unhandled SoftException (Ask Gemini)
                                        com.facebook.react.bridge.ReactNoCrashSoftException: raiseSoftException(onActivityResult(activity = "com.reproducerapp.MainActivity@1afbd28", requestCode = "100", resultCode = "-1", data = "Intent { (has extras) }")): Tried to access onActivityResult while context is not ready
                                        	at com.facebook.react.runtime.ReactHostImpl.raiseSoftException(ReactHostImpl.java:1025)
                                        	at com.facebook.react.runtime.ReactHostImpl.raiseSoftException(ReactHostImpl.java:1018)
                                        	at com.facebook.react.runtime.ReactHostImpl.onActivityResult(ReactHostImpl.java:776)
                                        	at com.facebook.react.ReactDelegate.onActivityResult(ReactDelegate.java:187)
                                        	at com.facebook.react.ReactActivityDelegate.onActivityResult(ReactActivityDelegate.java:192)
                                        	at com.facebook.react.ReactActivity.onActivityResult(ReactActivity.java:79)
                                        	at android.app.Activity.onActivityResult(Activity.java:7571)
                                        	at android.app.Activity.internalDispatchActivityResult(Activity.java:9470)
                                        	at android.app.Activity.dispatchActivityResult(Activity.java:9447)
                                        	at android.app.ActivityThread.deliverResults(ActivityThread.java:6025)
                                        	at android.app.ActivityThread.performResumeActivity(ActivityThread.java:5454)
                                        	at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:5500)
                                        	at android.app.servertransaction.ResumeActivityItem.execute(ResumeActivityItem.java:73)
                                        	at android.app.servertransaction.ActivityTransactionItem.execute(ActivityTransactionItem.java:63)
                                        	at android.app.servertransaction.TransactionExecutor.executeLifecycleItem(TransactionExecutor.java:169)
                                        	at android.app.servertransaction.TransactionExecutor.executeTransactionItems(TransactionExecutor.java:101)
                                        	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:80)
                                        	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2773)
                                        	at android.os.Handler.dispatchMessage(Handler.java:109)
                                        	at android.os.Looper.loopOnce(Looper.java:232)
                                        	at android.os.Looper.loop(Looper.java:317)
                                        	at android.app.ActivityThread.main(ActivityThread.java:8934)
                                        	at java.lang.reflect.Method.invoke(Native Method)
                                        	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)
                                        	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)
MANDATORY Reproducer

https://github.com/melissaosullivan/rn-activity-destroy-state-lost-repro/tree/main

Screenshots and Videos

No response

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

必須の ReproducerApp コマンドを使用して、説明されているライフサイクルを再現し、その後 ReactActivity.onActivityResult から ReactActivityDelegate、ReactDelegate、ReactHostImpl.onActivityResult を経由するスタックを追跡します。React コンテキストの準備が整う前に結果が配信されること、および完了したフローによって不足している RESULT と Completed のログが生成されることを確認します。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
android, java
領域
mobile-dev
issue の種類
バグ
難易度
4/5
見積もり時間
3〜5日
活発さ
停滞
明瞭さ
説明が足りない
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。