Interop Layer Android Display issue
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 127k
- Forks
- 25.3k
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 4
Description
Description
When the UnimplementedView is shown, if one of its child is an Animated View, the UnimplementedView will not display the 'XXX is not Fabric compatible yet'
React Native Version
0.72.4
Output of npx react-native info
System:
OS: macOS 13.2
CPU: (10) arm64 Apple M2 Pro
Memory: 57.34 MB / 16.00 GB
Shell:
version: 5.8.1
path: /bin/zsh
Binaries:
Node:
version: 18.15.0
path: /usr/local/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm:
version: 9.5.0
path: /usr/local/bin/npm
Watchman:
version: 2023.05.22.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /Users/thibault/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.2
- iOS 16.2
- macOS 13.1
- tvOS 16.1
- watchOS 9.1
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9514443
Xcode:
version: 14.2/14C18
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.18
path: /usr/bin/javac
Ruby:
version: 3.1.2
path: /Users/thibault/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
Steps to reproduce
Start the example below on new arch android
Snack, code example, screenshot, or link to a repository
This will demonstrate the issue: the first 3 box properly display the error but not the fourth one
import React from 'react';
import {Animated, SafeAreaView, Text, View} from 'react-native';
import {ShadowedView} from 'react-native-fast-shadow';
function App(): JSX.Element {
return (
<SafeAreaView>
<View style={{gap: 16}}>
<ShadowedView style={{width: 200, height: 200}} />
<ShadowedView style={{width: 200, height: 200}}>
<Text>Hello</Text>
</ShadowedView>
<ShadowedView style={{width: 200, height: 200}}>
<View>
<Text>Hello</Text>
</View>
</ShadowedView>
<ShadowedView style={{width: 200, height: 200}}>
<Animated.View>
<Text>Hello</Text>
</Animated.View>
</ShadowedView>
</View>
</SafeAreaView>
);
}
export default App;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Android UnimplementedView path and reproduce the supplied App example with new architecture enabled. Compare the first three ShadowedView cases with the Animated.View child; done means the fourth case also displays the “not Fabric compatible yet” message.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, react-native
- Domain
- mobile
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100