react-navigation / react-navigation/react-navigation.github.io

Convert v5.x.x samples to typescript in documentation

未關閉
#751 0 則留言 0 個 reaction 已指派 1 人 在 GitHub 檢視

@jarvisluong 已經在處理了。

開始於 2020年4月17日。

主要語言
JavaScript
星號
324
分支
2k
PR 合併指標
30 天內沒有已合併 PR

描述

Current Behavior

react-navigation v5.x.x has written in typescript but documentation samples are based on javascript. in some cases it's hard to guess what type must be used

for example, I don't know what type I should use for creating the navigationRef in this documentation

having the examples in typescript language would be a great help (especially for those like me that working with previous versions of react-navigation and going to migrate their codes, there are a lot of changes in both libraries and types and it's hard to find at least for me.)

Expected Behavior

having documentation examples in typescript language. (or even having a switch button in code sections to switch between typescript and javascript examples)

How to reproduce

just review the documentation website :)

Your Environment

I think it does not really matter for the feature request.

software version
iOS or Android
@react-navigation/native
react-native
expo
node
npm or yarn

貢獻指南

這個儲存庫沒有索引到貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。