react-navigation / react-navigation/react-navigation.github.io

Convert v5.x.x samples to typescript in documentation

Abierto
#751 0 comentarios 0 reacciones 1 asignado Ver en GitHub

@jarvisluong ya está trabajando en esto.

Desde el 17/4/2020.

Lenguaje dominante
JavaScript
Estrellas
324
Forks
2k
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Current Behavior

react-navigation v5.x.x has written in typescript but documentation samples are based on javascript. in some cases it's hard to guess what type must be used

for example, I don't know what type I should use for creating the navigationRef in this documentation

having the examples in typescript language would be a great help (especially for those like me that working with previous versions of react-navigation and going to migrate their codes, there are a lot of changes in both libraries and types and it's hard to find at least for me.)

Expected Behavior

having documentation examples in typescript language. (or even having a switch button in code sections to switch between typescript and javascript examples)

How to reproduce

just review the documentation website :)

Your Environment

I think it does not really matter for the feature request.

software version
iOS or Android
@react-navigation/native
react-native
expo
node
npm or yarn

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.