react-navigation / react-navigation/react-navigation.github.io
Convert v5.x.x samples to typescript in documentation
@jarvisluong 已经在做这个了。
开始于 2020年4月17日。
- 主要语言
- JavaScript
- 星标
- 324
- 派生
- 2k
- PR 合并指标
- 30 天内没有已合并 PR
描述
Current Behavior
react-navigation v5.x.x has written in typescript but documentation samples are based on javascript. in some cases it's hard to guess what type must be used
for example, I don't know what type I should use for creating the navigationRef in this documentation
having the examples in typescript language would be a great help (especially for those like me that working with previous versions of react-navigation and going to migrate their codes, there are a lot of changes in both libraries and types and it's hard to find at least for me.)
Expected Behavior
having documentation examples in typescript language. (or even having a switch button in code sections to switch between typescript and javascript examples)
How to reproduce
just review the documentation website :)
Your Environment
I think it does not really matter for the feature request.
| software | version |
|---|---|
| iOS or Android | |
| @react-navigation/native | |
| react-native | |
| expo | |
| node | |
| npm or yarn |
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。