"upload" only works with "compiled" benchmarks

My workflow for PyPy is

1. download latest version compiled on buildbot,
2. run benchmarks,
3. upload data (using command line option upload, which goes through compile.py, but should it?.

The cmd_upload function in compile.py assumes BenchmarkRevision.update_metadata from compile.py has been run to add commit information (commit_id, commit_branch, commit_date) and possibly patch_file to the json benchmark info. But because I am not running compile this info is lacking. Possible solutions:

• add a download_prebuilt option to compile.py and the Python class to support this workflow
• refactor the update_metadata method from BenchmarkRevision to become part of every benchmark run

Any thoughts? Should there be an upload.py separate from compile.py?

Inizia leggendo compile.py, in particolare cmd_upload, BenchmarkRevision.update_metadata e la classe Python. Traccia le differenze tra i benchmark Buildbot scaricati e i benchmark compilati e il modo in cui i metadati vengono aggiunti prima dell’upload. Il lavoro è completato quando il workflow PyPy descritto può caricare i dati dei benchmark senza richiedere un passaggio di compilazione locale e la separazione o il refactoring scelto è coperto dai test pertinenti.