"upload" only works with "compiled" benchmarks

My workflow for PyPy is

1. download latest version compiled on buildbot,
2. run benchmarks,
3. upload data (using command line option upload, which goes through compile.py, but should it?.

The cmd_upload function in compile.py assumes BenchmarkRevision.update_metadata from compile.py has been run to add commit information (commit_id, commit_branch, commit_date) and possibly patch_file to the json benchmark info. But because I am not running compile this info is lacking. Possible solutions:

• add a download_prebuilt option to compile.py and the Python class to support this workflow
• refactor the update_metadata method from BenchmarkRevision to become part of every benchmark run

Any thoughts? Should there be an upload.py separate from compile.py?

Commencez par lire compile.py, en particulier cmd_upload, BenchmarkRevision.update_metadata et la classe Python. Suivez en quoi les benchmarks Buildbot téléchargés diffèrent des benchmarks compilés et comment les métadonnées sont ajoutées avant l’upload. Le travail est terminé lorsque le workflow PyPy décrit peut envoyer des données de benchmark sans nécessiter d’étape de compilation locale, et que la séparation ou la refactorisation choisie est couverte par les tests pertinents.