"upload" only works with "compiled" benchmarks

My workflow for PyPy is

1. download latest version compiled on buildbot,
2. run benchmarks,
3. upload data (using command line option upload, which goes through compile.py, but should it?.

The cmd_upload function in compile.py assumes BenchmarkRevision.update_metadata from compile.py has been run to add commit information (commit_id, commit_branch, commit_date) and possibly patch_file to the json benchmark info. But because I am not running compile this info is lacking. Possible solutions:

• add a download_prebuilt option to compile.py and the Python class to support this workflow
• refactor the update_metadata method from BenchmarkRevision to become part of every benchmark run

Any thoughts? Should there be an upload.py separate from compile.py?

Empieza leyendo compile.py, especialmente cmd_upload, BenchmarkRevision.update_metadata y la clase Python. Sigue cómo difieren los benchmarks de Buildbot descargados de los benchmarks compilados y cómo se añaden los metadatos antes del upload. Se considerará terminado cuando el flujo de trabajo de PyPy descrito pueda cargar datos de benchmarks sin requerir un paso de compilación local, y la separación o refactorización elegida esté cubierta por las pruebas relevantes.