Number of source files reported can be confusing
オープン
@JukkaL がすでに取り組んでいます。
2019年9月16日 から。
needs discussion
priority-0-high
topic-usability
- 主要言語
- Python
- スター
- 20.6k
- フォーク
- 3.3k
- 平均マージ
- 1日 18時間
- マージ済み PR(30日)
- 54
説明
It's possible for mypy to report fewer source files than files with errors. Example:
Found 38 errors in 8 files (checked 2 source files)
This was surprising to me. It turns out that the number of source files only includes the files passed on the command line, and it doesn't include files found by following imports. It might be better to include all found files.
There are some open questions though:
- Should stubs be included in the count? My intuition says that they should not be, at least stubs from typeshed, since they are usually not what the user wants to be checked.
- What about PEP 561 inline typed files? Mypy doesn't report errors in these by default, so they aren't checked, strictly speaking. I'm not sure about this.
If we'd change "checked N source files" to "processed N source files", counting all .py files would seem like the logical thing to do (including PEP 561 inline typed files). However, 'processed' doesn't sound as nice as 'checked' to me.
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
評価
この issue はまだ評価されていません。