python / python/mypy

Number of source files reported can be confusing

Offen
#7,518 1 Kommentar 2 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@JukkaL arbeitet bereits daran.

Seit 16.9.2019.

needs discussion priority-0-high topic-usability
Vorherrschende Sprache
Python
Sterne
20.6k
Forks
3.3k
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

It's possible for mypy to report fewer source files than files with errors. Example:

Found 38 errors in 8 files (checked 2 source files)

This was surprising to me. It turns out that the number of source files only includes the files passed on the command line, and it doesn't include files found by following imports. It might be better to include all found files.

There are some open questions though:

  • Should stubs be included in the count? My intuition says that they should not be, at least stubs from typeshed, since they are usually not what the user wants to be checked.
  • What about PEP 561 inline typed files? Mypy doesn't report errors in these by default, so they aren't checked, strictly speaking. I'm not sure about this.

If we'd change "checked N source files" to "processed N source files", counting all .py files would seem like the logical thing to do (including PEP 561 inline typed files). However, 'processed' doesn't sound as nice as 'checked' to me.

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.