Improve PR review checklist
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 2.1k
- 派生
- 1k
- 平均合并
- 2 天 12 小时
- 30 天内合并 PR
- 12
描述
In https://github.com/python/cpython/pull/93823#issuecomment-1156152572 @erlend-aasland wrote a checklist about reviewing PRs.
In https://github.com/python/devguide/pull/914#issuecomment-1207257987, I suggested:
SGTM -- that's a nice list. I think it would be easier to add it in a separate PR though.
Reviewing PRs is currently documented in two places:
- https://devguide.python.org/getting-started/pull-request-lifecycle/#reviewing
- https://devguide.python.org/triage/triaging/#reviewing-patches
The former has been likely written from scratch after the HG->Git migration, whereas the latter formerly documented how to review patches attached to a bpo issue and then it has been adapted to GitHub. I think the best approach would be to enhance the pull-request-lifecycle with your list, and remove the duplicated info in triaging.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
阅读 pull-request-lifecycle 和 triaging 页面中的“Reviewing”部分,然后检查链接的 CPython pull request 评论中的检查清单。将相关检查清单整合到 pull-request-lifecycle 中,并移除 triaging 中重复的 Reviewing 指导;完成的标准是两个页面不再重复相同的信息。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- github
- 领域
- documentation
- Issue 类型
- 文档
- 难度
- 2/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 32/100