python / python/cpython

_Pickler_CommitFrame() always returns 0 and its return code is checked needlessly

未關閉
#85,019 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

3.10 stdlib type-feature
主要語言
Python
星號
77.2k
分支
36k
PR 合併指標
PR 指標待擷取

描述

BPO 40842
Nosy @remilapeyre

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-06-02.11:05:03.462>
labels = ['type-feature', 'library', '3.10']
title = '_Pickler_CommitFrame() always returns 0 and its return code is checked needlessly'
updated_at = <Date 2020-06-02.11:05:38.428>
user = 'https://github.com/remilapeyre'

bugs.python.org fields:

activity = <Date 2020-06-02.11:05:38.428>
actor = 'remi.lapeyre'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2020-06-02.11:05:03.462>
creator = 'remi.lapeyre'
dependencies = []
files = []
hgrepos = []
issue_num = 40842
keywords = []
message_count = 1.0
messages = ['370603']
nosy_count = 1.0
nosy_names = ['remi.lapeyre']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40842'
versions = ['Python 3.10']

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

首先在 CPython 程式庫程式碼中定位 _Pickler_CommitFrame() 的定義及其呼叫者,然後檢查其回傳值的處理方式。完成的標準是移除不必要的回傳碼檢查,同時維持 frame 提交的相同行為;執行相關的 pickle 測試加以驗證。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
backend
Issue 類型
重構
難度
2/5
預估耗時
1-3 小時
活躍度
停滯
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。