python / python/cpython

_Pickler_CommitFrame() always returns 0 and its return code is checked needlessly

未关闭
#85,019 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

3.10 stdlib type-feature
主要语言
Python
星标
77.2k
派生
36k
PR 合并指标
PR 指标待抓取

描述

BPO 40842
Nosy @remilapeyre

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2020-06-02.11:05:03.462>
labels = ['type-feature', 'library', '3.10']
title = '_Pickler_CommitFrame() always returns 0 and its return code is checked needlessly'
updated_at = <Date 2020-06-02.11:05:38.428>
user = 'https://github.com/remilapeyre'

bugs.python.org fields:

activity = <Date 2020-06-02.11:05:38.428>
actor = 'remi.lapeyre'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2020-06-02.11:05:03.462>
creator = 'remi.lapeyre'
dependencies = []
files = []
hgrepos = []
issue_num = 40842
keywords = []
message_count = 1.0
messages = ['370603']
nosy_count = 1.0
nosy_names = ['remi.lapeyre']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40842'
versions = ['Python 3.10']

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

首先在 CPython 库代码中定位 _Pickler_CommitFrame() 的定义及其调用者,然后检查其返回值的处理方式。完成的标准是移除不必要的返回码检查,同时帧提交保持相同的行为;运行相关的 pickle 测试进行验证。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
backend
Issue 类型
重构
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。