_Pickler_CommitFrame() always returns 0 and its return code is checked needlessly
Open
Nobody has claimed this yet.
3.10
stdlib
type-feature
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 36k
- PR merge metrics
- PR metrics pending
Description
| BPO | 40842 |
|---|---|
| Nosy | @remilapeyre |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2020-06-02.11:05:03.462>
labels = ['type-feature', 'library', '3.10']
title = '_Pickler_CommitFrame() always returns 0 and its return code is checked needlessly'
updated_at = <Date 2020-06-02.11:05:38.428>
user = 'https://github.com/remilapeyre'
bugs.python.org fields:
activity = <Date 2020-06-02.11:05:38.428>
actor = 'remi.lapeyre'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2020-06-02.11:05:03.462>
creator = 'remi.lapeyre'
dependencies = []
files = []
hgrepos = []
issue_num = 40842
keywords = []
message_count = 1.0
messages = ['370603']
nosy_count = 1.0
nosy_names = ['remi.lapeyre']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue40842'
versions = ['Python 3.10']
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the _Pickler_CommitFrame() definition and its callers in the CPython library code, then inspect how its return value is handled. Done means the needless return-code checks are removed while frame committing keeps the same behavior; run the relevant pickle tests to verify this.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100