C call specialization misses with `METH_CLASS`, `METH_STATIC` or `METH_COEXIST`
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Bug report
Bug description:
The specializer ignores METH_CLASS, METH_STATIC and METH_COEXIST when selecting a specialized C-call instruction, but the corresponding flag guards compare all flags. Affected calls fail these guards and fall back to generic CALL, even after repeated specialization. Return values are correct.
Save this as repro.py and run PYTHON_JIT=0 python repro.py with CPython 3.13 or newer:
import dis
import math
def counter(f):
call = [i for i in dis.get_instructions(f, adaptive=True)
if i.baseopname == "CALL"][-1]
cache = {name: data for name, _, data in call.cache_info}
return call.opname, cache["counter"]
def control():
math.gcd(4, 6)
def affected():
dict.fromkeys((), None)
for f in control, affected:
for _ in range(100):
f()
before = counter(f)
for _ in range(10):
f()
print(f.__name__, before[0], "hit" if counter(f) == before else "miss")
Output from an unpatched Linux build of 5539c2a5437 (3.16.0a0):
control CALL_BUILTIN_FAST hit
affected CALL_BUILTIN_FAST miss
Both call sites should report hit. The example detects misses by comparing the adaptive counter before and after ten calls.
For dict.fromkeys, the specializer masks out METH_CLASS and selects CALL_BUILTIN_FAST, but its guard requires exactly METH_FASTCALL. The actual flags are METH_FASTCALL | METH_CLASS. The method-descriptor guards and corresponding Tier 2 optimizer checks have the same mismatch.
I also reproduced the issue on Linux with CPython 3.13.14, 3.14.7, 3.14.7 free-threaded and 3.15.0rc2.
More cases, pystats results, timing measurements and source analysis.
I have a patch with Tier 1 and Tier 2 regression tests and will open a PR.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
- gh-157834
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
將提供的範例儲存為 repro.py,並在 CPython 3.13 或更新版本上使用 PYTHON_JIT=0 執行,以重現 adaptive-counter misses。閱讀 Python/specialize.c 中引用的 specialization,以及 Python/bytecodes.c 中的 guard 和 Tier 2 檢查。完成標準是兩個 call site 都回報 hit,且 Tier 1 和 Tier 2 regression tests 涵蓋受影響的 flags。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- compilers
- Issue 類型
- 缺陷
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 活躍
- 描述清晰度
- 描述清楚
- 新手友好度
- 35/100