Cleanup: Possible removal of some `__wasi__` special case handling
Chưa có ai nhận issue này.
- Ngôn ngữ chính
- Python
- Star
- 77.2k
- Fork
- 35.9k
- Chỉ số merge pull request
- Chỉ số pull request đang chờ
Mô tả
As a hopefully helpful cleanup task, I went through all the uses of __wasi__ special-casing in the CPython code and tried to figure out if any of them were not necessary anymore, mostly looking at the ones that might have been fixed by changes in wasi-libc.
I found a few, but the rest look like they are still needed. Happy to send PRs for the couple of ones at the top of the list which look like they can be safely removed.
The rest of the list is probably not useful, but I figured I would include it for completeness in case I have made some incorrect assumptions that stand out.
Full disclosure: I started off going through these one by one myself, but after the first pass to understand the patterns, I used Claude to scan and categorise the usages and to cross reference the wasi-libc changes where relevant. I did review the results carefully myself - especially spending time on the ones that looked like possible candidates for removal and doing my own searches for relevant issues/discussions. I've included some of the AI-generated summary, but I cut it down a lot and reworded it myself.
Good candidates for removal:
Modules/selectmodule.c:76 — define POLLPRI as no-op 0; missing from WASI SDK 16.
This is now defined in __header_poll.h as 0x0200 as of WASI SDK 33. It was added by wasi-libc PR #754 (merged); design discussion in issue #760 (open).
Modules/socketmodule.c:8428 — define the recv-truncated flag to work around wasi-libc issue #305, so MSG_TRUNC can be exported.
Looks like this was fixed by wasi-libc PR #391 (merged 2023-02-04); tracking issue #305 is still marked open but I think it could be closed now.
Possible candiates for removal:
linkat (posixmodule.c:4877) - This one needs further investigation or context it's not super clear to me why WASI was special-cased here.
Introduced by gh-81793 / PR #132517 (May 2025) which doesn't explicitly mention why the __wasi__ check was added. Possibly to preserve WASI's prior behaviour rather than risk changing the behavior, but it could be fine to remove. Removing it changes os.link's default symlink handling, so it could depend on what the WASi implementation does with that, I haven't tested removing this.
Could possibly be removed for preview2/3 when dropping support for preview1:
Parser/tokenizer/reader.c:718 — use a "borrowed fd" instead of dup().
wasi-libc implemented the dup-family for WASIp2/WASIp3 in PR #832 and PR #822, but the workaround must stay for preview1 (issue #459).
Probably need to be kept:
Modules/posixmodule.c:4157 — os.chmod becomes a no-op because WASI has no chmod or the underlying permission model.
wasi-libc added stubs in PR #463 that return ENOSYS, but CPython used these, it would cause a bunch of operations to error (same for relying on HAVE_CHMOD). The default of success is not great either (attempting to restrict permissions silently doesn't work), but it would need quite a bit of work to resolve all the cases where changing this would break something.
Modules/posixmodule.c:13549 and Modules/clinic/posixmodule.c.h:9534 — posix_fallocate was dropped in WASI preview2 due to inconsistent cross-OS semantics.
Python/fileutils.c:3145 — exclude WASI from the fast fcntl(F_GETFD) fd-validity path.
wasi-libc handles fcntl(F_GETFD), but it returns FD_CLOEXEC unconditionally without validating the fd, so it can't detect a bad fd. It's correct to fall back to fstat() for _Py_fd_is_valid.
Modules/_testinternalcapi.c:47, :241 — skip <dlfcn.h>/dladdr address classification.
wasi-libc has dlopen/dlsym stubs (PR #443) and shared-library build support (PR #429), but dladdr is still absent and there's no full runtime dynamic linking.
Modules/errnomodule.c:295 — alias ESHUTDOWN to EPIPE; missing from WASI SDK 16.
Looks like it's still needed. A WASI build uses __errno_values.h (EPIPE 64, no ESHUTDOWN), not musl's generic bits/errno.h. WASI preview1 has no such errno.
Special cases for WASM Stack size
I'm not super clear on the reasons for the smaller stack size limits. I suspect it's related to the 16MiB stack size specified here: https://github.com/python/cpython/blob/41b3f0af266b408438cab36625c6ad71040d38e5/configure.ac#L2500 (side note --stack-first is apparently the default now, so perhaps in future that can be removed).
I suspect these ones need to stay.
Parser/parser.c:11— lowerMAXSTACKTools/peg_generator/pegen/c_generator.py:42— the template that generates theparser.ccap above.Python/marshal.c:47— reducedMAX_MARSHAL_STACK_DEPTH
Threading stuff
I didn't go as deep on the threading cases, but as far as I can tell all of these need to stay. There's still no pause() and pthread_exit or pthread_cleanup_push etc. Though there is a discussion on adding pthread_exit to WASI.
Include/pyport.h:478— leavePy_CAN_START_THREADSundefined; non-threaded WASI has no threads.Include/cpython/pthread_stubs.h:21— coaxpthread_*type declarations out ofbits/alltypes.hvia__NEED_*macros when threads are stubbed.Python/thread_pthread.h:421—abort()instead ofpthread_exit, whichwasi-threadslacks. Tracked upstream by wasi-threads#7 ("Iswasi_thread_exitneeded?"), still open (created Oct 2022)Python/thread_pthread.h:436—sleep(9999999)instead ofpause(), whichwasi-libclacks.Modules/_testcapimodule.c:2448,:2463,:2469— nopthread_cleanup_push/pop
Unavailable features
Also didn't look closely at these ones, but I suspect they need to stay - I don't see the semantics of the cpu time clocks changing in WASI any time soon, also I'm not clear on what it would take to implement subinterpreters.
Modules/timemodule.c:80,:1272,:1411,:2146— don't usetimes()on WASI; no meaningful process CPU accounting (gh-115714).Modules/timemodule.c:1347— disable process-CPU-time viaCLOCK_PROCESS_CPUTIME_ID.Modules/timemodule.c:1549— disable thread-CPU-time viaCLOCK_THREAD_CPUTIME_ID.Python/sysmodule.c:3765— reportsupports_isolated_interpreters = False; PEP-734 subinterpreters aren't enabled on WASM builds yet.
Vendored third-party code
Changes to these should be considered upstream.
Objects/mimalloc/**andInclude/internal/mimalloc/**— mimalloc's own WASI port.Modules/expat/xmlparse.c— vendored Expat's own WASI handling.
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Hướng nghiên cứu
Bắt đầu với các thay đổi ứng viên trong Modules/selectmodule.c, Modules/socketmodule.c và Modules/posixmodule.c, sau đó so sánh từng trường hợp đặc biệt với hành vi wasi-libc được trích dẫn. Xác minh các hệ quả đối với preview1 và preview2 trước khi thay đổi bất cứ điều gì. Được xem là hoàn tất khi chỉ phần xử lý wasi đã lỗi thời bị loại bỏ, trong khi các trường hợp tương thích còn lại vẫn có lý do chính đáng và bản build WASI vẫn hoạt động.
Do mô hình lập chỉ mục viết ra từ nội dung của issue.
Đánh giá
- Công nghệ
- c, python, wasm
- Lĩnh vực
- build-system, operating-systems
- Loại issue
- Tái cấu trúc
- Độ khó
- 5/5
- Thời gian dự kiến
- Hơn một tuần
- Mức độ hoạt động
- Sôi nổi
- Độ rõ ràng
- Khá rõ ràng
- Mức phù hợp với người mới
- 38/100