python / python/cpython

Cleanup: Possible removal of some `__wasi__` special case handling

Abierto
#156,692 1 comentario 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

extension-modules interpreter-core OS-wasi type-refactor
Lenguaje dominante
Python
Estrellas
77.2k
Forks
35.9k
Métricas de merge de PR
Métricas de PR pendientes

Descripción

As a hopefully helpful cleanup task, I went through all the uses of __wasi__ special-casing in the CPython code and tried to figure out if any of them were not necessary anymore, mostly looking at the ones that might have been fixed by changes in wasi-libc.

I found a few, but the rest look like they are still needed. Happy to send PRs for the couple of ones at the top of the list which look like they can be safely removed.

The rest of the list is probably not useful, but I figured I would include it for completeness in case I have made some incorrect assumptions that stand out.

Full disclosure: I started off going through these one by one myself, but after the first pass to understand the patterns, I used Claude to scan and categorise the usages and to cross reference the wasi-libc changes where relevant. I did review the results carefully myself - especially spending time on the ones that looked like possible candidates for removal and doing my own searches for relevant issues/discussions. I've included some of the AI-generated summary, but I cut it down a lot and reworded it myself.

Good candidates for removal:

Modules/selectmodule.c:76 — define POLLPRI as no-op 0; missing from WASI SDK 16.

This is now defined in __header_poll.h as 0x0200 as of WASI SDK 33. It was added by wasi-libc PR #754 (merged); design discussion in issue #760 (open).

Modules/socketmodule.c:8428 — define the recv-truncated flag to work around wasi-libc issue #305, so MSG_TRUNC can be exported.

Looks like this was fixed by wasi-libc PR #391 (merged 2023-02-04); tracking issue #305 is still marked open but I think it could be closed now.

Possible candiates for removal:

linkat (posixmodule.c:4877) - This one needs further investigation or context it's not super clear to me why WASI was special-cased here.

Introduced by gh-81793 / PR #132517 (May 2025) which doesn't explicitly mention why the __wasi__ check was added. Possibly to preserve WASI's prior behaviour rather than risk changing the behavior, but it could be fine to remove. Removing it changes os.link's default symlink handling, so it could depend on what the WASi implementation does with that, I haven't tested removing this.

Could possibly be removed for preview2/3 when dropping support for preview1:

Parser/tokenizer/reader.c:718 — use a "borrowed fd" instead of dup().

wasi-libc implemented the dup-family for WASIp2/WASIp3 in PR #832 and PR #822, but the workaround must stay for preview1 (issue #459).

Probably need to be kept:

Modules/posixmodule.c:4157os.chmod becomes a no-op because WASI has no chmod or the underlying permission model.
wasi-libc added stubs in PR #463 that return ENOSYS, but CPython used these, it would cause a bunch of operations to error (same for relying on HAVE_CHMOD). The default of success is not great either (attempting to restrict permissions silently doesn't work), but it would need quite a bit of work to resolve all the cases where changing this would break something.

Modules/posixmodule.c:13549 and Modules/clinic/posixmodule.c.h:9534posix_fallocate was dropped in WASI preview2 due to inconsistent cross-OS semantics.

Python/fileutils.c:3145 — exclude WASI from the fast fcntl(F_GETFD) fd-validity path.
wasi-libc handles fcntl(F_GETFD), but it returns FD_CLOEXEC unconditionally without validating the fd, so it can't detect a bad fd. It's correct to fall back to fstat() for _Py_fd_is_valid.

Modules/_testinternalcapi.c:47, :241 — skip <dlfcn.h>/dladdr address classification.
wasi-libc has dlopen/dlsym stubs (PR #443) and shared-library build support (PR #429), but dladdr is still absent and there's no full runtime dynamic linking.

Modules/errnomodule.c:295 — alias ESHUTDOWN to EPIPE; missing from WASI SDK 16.
Looks like it's still needed. A WASI build uses __errno_values.h (EPIPE 64, no ESHUTDOWN), not musl's generic bits/errno.h. WASI preview1 has no such errno.

Special cases for WASM Stack size

I'm not super clear on the reasons for the smaller stack size limits. I suspect it's related to the 16MiB stack size specified here: https://github.com/python/cpython/blob/41b3f0af266b408438cab36625c6ad71040d38e5/configure.ac#L2500 (side note --stack-first is apparently the default now, so perhaps in future that can be removed).

I suspect these ones need to stay.

Threading stuff

I didn't go as deep on the threading cases, but as far as I can tell all of these need to stay. There's still no pause() and pthread_exit or pthread_cleanup_push etc. Though there is a discussion on adding pthread_exit to WASI.

Unavailable features

Also didn't look closely at these ones, but I suspect they need to stay - I don't see the semantics of the cpu time clocks changing in WASI any time soon, also I'm not clear on what it would take to implement subinterpreters.

Vendored third-party code

Changes to these should be considered upstream.

  • Objects/mimalloc/** and Include/internal/mimalloc/** — mimalloc's own WASI port.
  • Modules/expat/xmlparse.c — vendored Expat's own WASI handling.

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con los posibles cambios en Modules/selectmodule.c, Modules/socketmodule.c y Modules/posixmodule.c, y luego compara cada caso especial con el comportamiento citado de wasi-libc. Verifica las implicaciones para preview1 y preview2 antes de cambiar nada. Se considera terminado cuando solo se haya eliminado el manejo obsoleto de wasi, mientras que los casos de compatibilidad restantes sigan estando justificados y la compilación de WASI siga funcionando.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
c, python, wasm
Área
build-system, operating-systems
Tipo de issue
Refactorización
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
38/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.