Data race creating Tcl interpreters concurrently via `_tkinter.create` under free-threading
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
Bug report
Bug description:
_tkinter declares Py_MOD_GIL_NOT_USED, so under --disable-gil the GIL no longer serializes calls into it. _tkinter.create() creates a new Tcl interpreter with Tcl_CreateInterp():
reached from _tkinter_create_impl:
_tkinter does not serialize interpreter creation, so two threads calling _tkinter.create() run Tcl_CreateInterp() concurrently. That triggers Tcl's first-time global initialization, where Tcl_MutexLock lazily initializes a static mutex. That init is not concurrency-safe, so one thread's pthread_mutex_init (write) races with another thread's pthread_mutex_lock (atomic read) on the same Tcl global.
Reproducer:
import _tkinter
from threading import Thread
def worker():
for _ in range(20000):
try:
_tkinter.create(None, '', 'Tk', False, 1, False, False, None)
except Exception:
pass
ts = [Thread(target=worker) for _ in range(12)]
for t in ts: t.start()
for t in ts: t.join()
TSAN Report (Tested on Linux, Tcl 8.6.14, with useTk=False):
==================
WARNING: ThreadSanitizer: data race (pid=650542)
Atomic read of size 1 at 0x72a0000145d0 by thread T2:
#0 pthread_mutex_lock <null>
#1 TclCreateExecEnv /usr/src/tcl8.6-8.6.14+dfsg-1build1/generic/tclExecute.c:936:5
#2 cfunction_vectorcall_FASTCALL /cpython/Objects/methodobject.c:449:24
#3 _PyObject_VectorcallTstate /cpython/./Include/internal/pycore_call.h:144:11
#4 PyObject_Vectorcall /cpython/Objects/call.c:327:12
#5 _Py_VectorCallInstrumentation_StackRefSteal /cpython/Python/ceval.c:768:11
#6 _PyEval_EvalFrameDefault /cpython/Python/generated_cases.c.h:1906:35
Previous write of size 1 at 0x72a0000145d0 by thread T1 (mutexes: write M0):
#0 pthread_mutex_init <null>
#1 Tcl_MutexLock /usr/src/tcl8.6-8.6.14+dfsg-1build1/unix/tclUnixThrd.c:430:6
#2 cfunction_vectorcall_FASTCALL /cpython/Objects/methodobject.c:449:24
#3 _PyObject_VectorcallTstate /cpython/./Include/internal/pycore_call.h:144:11
#4 PyObject_Vectorcall /cpython/Objects/call.c:327:12
#5 _Py_VectorCallInstrumentation_StackRefSteal /cpython/Python/ceval.c:768:11
#6 _PyEval_EvalFrameDefault /cpython/Python/generated_cases.c.h:1906:35
Location is heap block of size 16384 at 0x72a000014000 allocated by thread T1:
#0 malloc <null>
#1 GetBlocks /usr/src/tcl8.6-8.6.14+dfsg-1build1/generic/tclThreadAlloc.c:1044:17
#2 cfunction_vectorcall_FASTCALL /cpython/Objects/methodobject.c:449:24
#3 _PyObject_VectorcallTstate /cpython/./Include/internal/pycore_call.h:144:11
#4 PyObject_Vectorcall /cpython/Objects/call.c:327:12
#5 _Py_VectorCallInstrumentation_StackRefSteal /cpython/Python/ceval.c:768:11
#6 _PyEval_EvalFrameDefault /cpython/Python/generated_cases.c.h:1906:35
Mutex M0 (0x7fffb1dff7a0) created at:
#0 pthread_mutex_lock <null>
#1 Tcl_MutexLock /usr/src/tcl8.6-8.6.14+dfsg-1build1/unix/tclUnixThrd.c:423:2
#2 _PyImport_RunModInitFunc /cpython/./Python/importdl.c:436:19
#3 import_run_extension /cpython/Python/import.c:2167:14
#4 _imp_create_dynamic_impl /cpython/Python/import.c:5565:11
#5 _imp_create_dynamic /cpython/Python/clinic/import.c.h:489:20
#6 cfunction_vectorcall_FASTCALL /cpython/Objects/methodobject.c:449:24
#7 _PyVectorcall_Call /cpython/Objects/call.c:273:16
#8 _PyObject_Call /cpython/Objects/call.c:348:16
#9 PyObject_Call /cpython/Objects/call.c:373:12
#10 _PyEval_EvalFrameDefault /cpython/Python/generated_cases.c.h:2831:38
SUMMARY: ThreadSanitizer: data race (/cpython/cpython-tsan/bin/python3.16t+0xfad6e) in pthread_mutex_lock
==================
On macOS with Tcl/Tk 9.0 the same reproducer surfaces the _tkinter module-global data races (PyOS_InputHook, tcl_lock). With useTk=True it crashes inside Tk's own display initialization.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
- gh-156342
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 Modules/_tkinter.c 中的 Tcl_CreateInterp 和 _tkinter_create_impl 开始,然后在带有 ThreadSanitizer 的 free-threaded CPython 构建下重现并发调用。将 Linux 上的 Tcl race 与报告中描述的 macOS 模块全局 race 进行比较。在给定的 reproducer 下创建解释器时不再报告已识别的 race 且不再崩溃,即表示完成;gh-156342 已链接以提供上下文。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- c, python
- 领域
- desktop, operating-systems
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100