Improve Py_mod_multiple_interpreters and Py_mod_gil Usability
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 35.9k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Feature or enhancement
Proposal:
Here are some deficiencies:
- the slot name "Py_mod_multiple_interpreters" is a bit long
- the "Py_MOD_MULTIPLE_INTERPRETERS_*" slot value names are a bit long
- the slot name "Py_mod_gil" is overly coupled to the GIL (it's really about thread safety)
- the difference between
Py_MOD_MULTIPLE_INTERPRETERS_SUPPORTEDandPy_MOD_PER_INTERPRETER_GIL_SUPPORTEDis unclear Py_MOD_PER_INTERPRETER_GIL_SUPPORTEDapplies to the vast majority of extensions and should be the defaultPy_mod_gildoesn't have an option that explicitly covers the case where an external dependency is not thread-safe- currently
Py_MOD_MULTIPLE_INTERPRETERS_SUPPORTEDimplies an external dependency is not thread-safe and/or isolated to each interpreter; it should be the other way around (and be a synonym forPy_MOD_PER_INTERPRETER_GIL_SUPPORTED), which would introduce a need for aPy_MOD_PER_INTERPRETER_GIL_NOT_SUPPORTED
We could take a simple approach, working with the existing slots:
- (maybe) shorten the names
- add
Py_MOD_PER_INTERPRETER_GIL_NOT_SUPPORTED - add something like
Py_MOD_GIL_USED_FOR_EXTERNAL
I think we could do better, by replacing the existing slots with new ones that focus explicitly on what we care about:
- new module def slot:
Py_mod_isolationPy_MOD_NOT_ISOLATED- the module has process-global state and/or objects (e.g. static types)Py_MOD_ISOLATED(default) - the module's state/objects have been isolated to the module (i.e interpreter)
- new module def slot:
Py_mod_threadsafePy_MOD_NOT_THREADSAFE(default) - the module's own state/code is not thread-safePy_MOD_THREADSAFE- the module's state/code are thread-safe; external dependencies are covered byPy_mod_external_libs
- new module def slot:
Py_mod_external_libsPy_MOD_EXTERN_NOT_THREADSAFE- at least one external dependency is not thread-safe (may be used without the GIL held)Py_MOD_EXTERN_NOT_ISOLATED- at least one external dependency is not isolated to the module object (i.e. interpreter)Py_MOD_EXTERN_ISOLATED(default) - all external dependencies are isolated and using them is thread-safe
- for
Py_mod_isolationandPy_mod_threadsafe, external dependencies are covered byPy_mod_external_libs - deprecate
Py_mod_multiple_interpretersslot - deprecate
Py_mod_gilslot
Regarding the defaults, for Py_mod_isolation, multi-phase init implies isolation (per PEP 489). For Py_mod_external_libs, we assume that the vast majority of modules will not have problematic dependencies.
Equivalents to current usage:
| Py_mod_threadsafe | Py_mod_external_libs | Py_mod_gil | |
|---|---|---|---|
| Py_MOD_NOT_THREADSAFE | * | Py_MOD_GIL_USED | |
| Py_MOD_THREADSAFE | Py_MOD_EXTERNAL_NOT_THREADSAFE | Py_MOD_GIL_USED | |
| Py_MOD_THREADSAFE | Py_MOD_EXTERNAL_NOT_ISOLATED | Py_MOD_GIL_NOT_USED | |
| Py_MOD_THREADSAFE | Py_MOD_EXTERNAL_ISOLATED | Py_MOD_GIL_NOT_USED |
| Py_mod_isolation | Py_mod_external_libs | Py_mod_multiple_interpreters | |
|---|---|---|---|
| Py_MOD_NOT_ISOLATED | * | Py_MOD_MULTIPLE_INTERPRETERS_NOT_SUPPORTED | |
| Py_MOD_ISOLATED | Py_MOD_EXTERNAL_NOT_THREADSAFE | Py_MOD_MULTIPLE_INTERPRETERS_SUPPORTED | |
| Py_MOD_ISOLATED | Py_MOD_EXTERNAL_NOT_ISOLATED | Py_MOD_MULTIPLE_INTERPRETERS_SUPPORTED | |
| Py_MOD_ISOLATED | Py_MOD_EXTERNAL_ISOLATED | Py_MOD_PER_INTERPRETER_GIL_SUPPORTED |
CC @encukou
Has this already been discussed elsewhere?
No response given
Links to previous discussion of this feature:
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
El issue no menciona archivos fuente ni pruebas; comienza localizando las definiciones existentes de los slots Py_mod_multiple_interpreters y Py_mod_gil y revisando su comportamiento actual. Resuelve primero con los maintainers los nombres de los slots propuestos, los valores predeterminados y las deprecations; el trabajo requiere un diseño acordado, además de la implementación y las pruebas correspondientes.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- backend
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100