PyREPL does not handle `wRepeatCount` on Windows, causing incorrect 'dead key' behavior
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Bug report
Bug description:
PyREPL (introduced in Python 3.13) fails to account for the wRepeatCount field in the KEY_EVENT_RECORD on Windows, resulting in incorrect behavior when keys are pressed repeatedly in the REPL. This issue is reproducible in the Windows Terminal on Windows 10 or 11, specifically when using a keyboard layout with dead keys (e.g., US International layout).
This issue can be bothering as it messes with muscle memory when typing quotes in the new PyREPL (which otherwise is AWESOME!)
Steps to Reproduce:
- Open Python 3.13+ in the Windows Terminal (NOT in an older conhost.exe-based terminal) on Windows 10 or 11.
- Use a keyboard layout with dead keys, such as the US International layout.
- Type a dead key character (e.g.,
',",^,`, or~) into the REPL input.- Expected behavior: No character is typed, as the dead key is waiting for the next key to combine.
- Actual behavior: No character is typed, which is correct.
- Type the same dead key again.
- Expected behavior: The character corresponding to the dead key should be typed twice.
- Actual behavior: The character is only typed once.
Root Cause:
The Windows Terminal sends a single key event with wRepeatCount == 2 when a key is pressed repeatedly. PyREPL does not check the wRepeatCount value, so the REPL only processes the key press once. In contrast, conhost.exe-based terminals send two separate key events for the repeated key press, causing the REPL to handle the input correctly in those environments.
Desired Fix:
Modify PyREPL to correctly handle the wRepeatCount value in the KEY_EVENT_RECORD. When wRepeatCount > 1, the corresponding key should be processed the specified number of times to ensure correct handling of repeated key presses.
CPython versions tested on:
3.13, 3.14, CPython main branch
Operating systems tested on:
Windows
Linked PRs
- gh-127948
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 PyREPL 的 Windows KEY_EVENT_RECORD 輸入處理開始,檢查重複按鍵事件是如何處理的。在使用 dead-key 鍵盤配置的 Windows Terminal 中重現 dead-key 行為,然後驗證 wRepeatCount 大於一的事件會產生預期的重複字元。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- cli, operating-systems
- Issue 類型
- 缺陷
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 停滯
- 描述清晰度
- 描述清楚
- 新手友好度
- 25/100