PyREPL does not handle `wRepeatCount` on Windows, causing incorrect 'dead key' behavior
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 36k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Bug report
Bug description:
PyREPL (introduced in Python 3.13) fails to account for the wRepeatCount field in the KEY_EVENT_RECORD on Windows, resulting in incorrect behavior when keys are pressed repeatedly in the REPL. This issue is reproducible in the Windows Terminal on Windows 10 or 11, specifically when using a keyboard layout with dead keys (e.g., US International layout).
This issue can be bothering as it messes with muscle memory when typing quotes in the new PyREPL (which otherwise is AWESOME!)
Steps to Reproduce:
- Open Python 3.13+ in the Windows Terminal (NOT in an older conhost.exe-based terminal) on Windows 10 or 11.
- Use a keyboard layout with dead keys, such as the US International layout.
- Type a dead key character (e.g.,
',",^,`, or~) into the REPL input.- Expected behavior: No character is typed, as the dead key is waiting for the next key to combine.
- Actual behavior: No character is typed, which is correct.
- Type the same dead key again.
- Expected behavior: The character corresponding to the dead key should be typed twice.
- Actual behavior: The character is only typed once.
Root Cause:
The Windows Terminal sends a single key event with wRepeatCount == 2 when a key is pressed repeatedly. PyREPL does not check the wRepeatCount value, so the REPL only processes the key press once. In contrast, conhost.exe-based terminals send two separate key events for the repeated key press, causing the REPL to handle the input correctly in those environments.
Desired Fix:
Modify PyREPL to correctly handle the wRepeatCount value in the KEY_EVENT_RECORD. When wRepeatCount > 1, the corresponding key should be processed the specified number of times to ensure correct handling of repeated key presses.
CPython versions tested on:
3.13, 3.14, CPython main branch
Operating systems tested on:
Windows
Linked PRs
- gh-127948
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza por el manejo de entradas de Windows KEY_EVENT_RECORD de PyREPL e inspecciona cómo se procesan los eventos de teclas repetidos. Reproduce el comportamiento de dead-key en Windows Terminal con una distribución de teclado dead-key y, a continuación, verifica que un evento con wRepeatCount mayor que uno produzca los caracteres repetidos esperados.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- cli, operating-systems
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Estancado
- Claridad
- Bien especificado
- Aptitud para principiantes
- 25/100