PyREPL does not handle `wRepeatCount` on Windows, causing incorrect 'dead key' behavior
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Python
- Sterne
- 77.2k
- Forks
- 35.9k
- PR-Merge-Kennzahlen
- PR-Kennzahlen ausstehend
Beschreibung
Bug report
Bug description:
PyREPL (introduced in Python 3.13) fails to account for the wRepeatCount field in the KEY_EVENT_RECORD on Windows, resulting in incorrect behavior when keys are pressed repeatedly in the REPL. This issue is reproducible in the Windows Terminal on Windows 10 or 11, specifically when using a keyboard layout with dead keys (e.g., US International layout).
This issue can be bothering as it messes with muscle memory when typing quotes in the new PyREPL (which otherwise is AWESOME!)
Steps to Reproduce:
- Open Python 3.13+ in the Windows Terminal (NOT in an older conhost.exe-based terminal) on Windows 10 or 11.
- Use a keyboard layout with dead keys, such as the US International layout.
- Type a dead key character (e.g.,
',",^,`, or~) into the REPL input.- Expected behavior: No character is typed, as the dead key is waiting for the next key to combine.
- Actual behavior: No character is typed, which is correct.
- Type the same dead key again.
- Expected behavior: The character corresponding to the dead key should be typed twice.
- Actual behavior: The character is only typed once.
Root Cause:
The Windows Terminal sends a single key event with wRepeatCount == 2 when a key is pressed repeatedly. PyREPL does not check the wRepeatCount value, so the REPL only processes the key press once. In contrast, conhost.exe-based terminals send two separate key events for the repeated key press, causing the REPL to handle the input correctly in those environments.
Desired Fix:
Modify PyREPL to correctly handle the wRepeatCount value in the KEY_EVENT_RECORD. When wRepeatCount > 1, the corresponding key should be processed the specified number of times to ensure correct handling of repeated key presses.
CPython versions tested on:
3.13, 3.14, CPython main branch
Operating systems tested on:
Windows
Linked PRs
- gh-127948
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne bei der Windows KEY_EVENT_RECORD-Eingabeverarbeitung von PyREPL und untersuche, wie wiederholte Tastaturereignisse verarbeitet werden. Reproduziere das Verhalten von dead-key in Windows Terminal mit einem dead-key-Tastaturlayout und verifiziere anschließend, dass ein Ereignis mit wRepeatCount größer als eins die erwarteten wiederholten Zeichen erzeugt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- cli, operating-systems
- Issue-Typ
- Bug
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 25/100