Disallow arbitrary types in co_consts
@encukou 已经在做这个了。
开始于 2024年8月9日。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 36k
- PR 合并指标
- PR 指标待抓取
描述
co_consts can contain values of any type, including mutable ones. For example:
def f():
print(())
code = f.__code__
code = code.replace(co_consts=(None, []))
exec(code)
This is dangerous especially in the free-threaded build, which
- de-duplicates constants and
- immortalizes constants and relies them to be immortal
The “feature” is untested, as seen from the above snippet failing an assertion in free-threaded build.
Mutable subclasses of immutable built-in types are especially “interesting” here.
A solution would be to only allow built-in immutable marshallable types (booleans, integers, floating-point numbers, complex numbers, strings, bytes, tuples, frozensets, code objects, None, Ellipsis, StopIteration), excluding sublasses. That's a backwards-incompatible change.
Note that CPython now already recursively analyzes co_consts; there's little cost to doing additional inspection.
My current plan is:
- Disallow “bad” values in free-threaded builds in 3.14, as this build is still experimental and this breaks vital invariants.
- Deprecate “bad” values in regular build, and initially plan to disallow them in 3.16. (Minimal PEP-387 deprecation period chosen because this “feature” is very likely to interfere with optimizations, and unlikely to get proper test coverage.)
Until then, please avoid assuming that code constants are “sane”. (cc @brandtbucher @markshannon @colesbury)
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。