python / python/cpython

Disallow arbitrary types in co_consts

Offen
#122,850 2 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@encukou arbeitet bereits daran.

Seit 09.8.2024.

interpreter-core performance
Vorherrschende Sprache
Python
Sterne
77.2k
Forks
35.9k
PR-Merge-Kennzahlen
PR-Kennzahlen ausstehend

Beschreibung

co_consts can contain values of any type, including mutable ones. For example:

def f():
    print(())

code = f.__code__
code = code.replace(co_consts=(None, []))
exec(code)

This is dangerous especially in the free-threaded build, which

  • de-duplicates constants and
  • immortalizes constants and relies them to be immortal

The “feature” is untested, as seen from the above snippet failing an assertion in free-threaded build.

Mutable subclasses of immutable built-in types are especially “interesting” here.

A solution would be to only allow built-in immutable marshallable types (booleans, integers, floating-point numbers, complex numbers, strings, bytes, tuples, frozensets, code objects, None, Ellipsis, StopIteration), excluding sublasses. That's a backwards-incompatible change.

Note that CPython now already recursively analyzes co_consts; there's little cost to doing additional inspection.

My current plan is:

  • Disallow “bad” values in free-threaded builds in 3.14, as this build is still experimental and this breaks vital invariants.
  • Deprecate “bad” values in regular build, and initially plan to disallow them in 3.16. (Minimal PEP-387 deprecation period chosen because this “feature” is very likely to interfere with optimizations, and unlikely to get proper test coverage.)

Until then, please avoid assuming that code constants are “sane”. (cc @brandtbucher @markshannon @colesbury)

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.