plotly / plotly/plotly.py

setting up a development environment is difficult

未關閉
#4,380 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

bug infrastructure P2
主要語言
Python
星號
18.8k
分支
2.8k
平均合併
16 小時 26 分鐘
30 天內合併 PR
21

描述

I recently spun up a dev environment for contributing a PR to plotly.py and ran into some issues that I think can be addressed fairly readily.

  1. pytest is pinned to 3.5.1 in packages/python/plotly/optional-requirements.txt and this version simply didn't run, failing with an internal TypeError. I upgraded it to 7.4.2 and it worked. Is there a reason its pinned to such an old version? can this be unpinned?
  2. contributing.md does not currently mention the dependancy on Plotly Orca. I was rather surprised to come back to all my tests failing, and somewhat hilariously the orca Ubuntu screen reader reading a large chunk of Pytest's terminal output to me. Just adding an external dependency in the testing section would do the trick I reckon.
  3. There were a number of missing packages required by optional tests that aren't in packages/python/plotly/optional-requirements.txt so those tests failed. The following packages need to be added: polars vaex scikit-image statsmodels pyarrow

btw for 1,the error thrown by pytest 3.5.1 is:

  File "/home/ned/.pyenv/versions/3.11.6/envs/book/lib/python3.11/site-packages/_pytest/assertion/rewrite.py", line 332, in _rewrite_test
    co = compile(tree, fn.strpath, "exec", dont_inherit=True)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: required field "lineno" missing from alias

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

先從 packages/python/plotly/optional-requirements.txt 和 contributing.md 開始,然後在所回報的 Python 3.11 環境中重現 pytest 3.5.1 失敗問題。檢查選用測試的相依性和測試文件。當文件中描述的設定能夠執行測試,且不會出現所回報的 pytest 錯誤或因缺少套件而失敗時,即表示完成。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
build-system, documentation, testing
Issue 類型
缺陷
難度
3/5
預估耗時
1-2 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。