plotly / plotly/plotly.py

setting up a development environment is difficult

未关闭
#4,380 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

bug infrastructure P2
主要语言
Python
星标
18.8k
派生
2.8k
平均合并
16 小时 26 分钟
30 天内合并 PR
21

描述

I recently spun up a dev environment for contributing a PR to plotly.py and ran into some issues that I think can be addressed fairly readily.

  1. pytest is pinned to 3.5.1 in packages/python/plotly/optional-requirements.txt and this version simply didn't run, failing with an internal TypeError. I upgraded it to 7.4.2 and it worked. Is there a reason its pinned to such an old version? can this be unpinned?
  2. contributing.md does not currently mention the dependancy on Plotly Orca. I was rather surprised to come back to all my tests failing, and somewhat hilariously the orca Ubuntu screen reader reading a large chunk of Pytest's terminal output to me. Just adding an external dependency in the testing section would do the trick I reckon.
  3. There were a number of missing packages required by optional tests that aren't in packages/python/plotly/optional-requirements.txt so those tests failed. The following packages need to be added: polars vaex scikit-image statsmodels pyarrow

btw for 1,the error thrown by pytest 3.5.1 is:

  File "/home/ned/.pyenv/versions/3.11.6/envs/book/lib/python3.11/site-packages/_pytest/assertion/rewrite.py", line 332, in _rewrite_test
    co = compile(tree, fn.strpath, "exec", dont_inherit=True)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: required field "lineno" missing from alias

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

先从 packages/python/plotly/optional-requirements.txt 和 contributing.md 开始,然后在所报告的 Python 3.11 环境中复现 pytest 3.5.1 失败问题。检查可选测试依赖项和测试文档。当文档中描述的设置能够运行测试,且不会出现所报告的 pytest 错误或缺少软件包导致的失败时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
build-system, documentation, testing
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
38/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。