Using opacityscale with surface results in ordering by addition order, not depth
まだ誰も着手していません。
- 主要言語
- R
- スター
- 2.7k
- フォーク
- 641
- PR マージ指標
- 30日以内にマージされた PR はありません
説明
Hi, been using plotly with R for a while now and really loving it - thanks for assembling such a phenomenal program! I'd like to report a bug found while plotting multiple surface objects, which causes them to layer in the order they're added (using %>%) rather than the "depth" at which they should really render in the figure. See below for code and examples.
The "opacityscale" function is a new one from the dev branch (and I don't think problems with it have been reported on here before) so this question may be a better fit for https://github.com/plotly/plotly.js instead, where there's a bit more discussion about it and the original implementation, but I don't know JavaScript and can't provide a reprex there.
This is great:

This is not great (same figure rotated to look from below):

It only seems to show up if the opacityscale parameter is added, even if the opacity is set to 1 for all values.
Renders fine:
# devtools::install_github("ropensci/plotly")
library(plotly)
df <- data.frame(x=1:10, y=1:10)
surface_data <- matrix(1:100, nrow=10, ncol=10)
z_mat <- matrix(0, nrow = 10, ncol = 10)
plot_ly(df, x=~x, y=~y) %>%
add_trace(type="surface",
z=z_mat,
surfacecolor=surface_data,
colorscale=list(list(0, 1), list("red", "orange"))) %>%
add_trace(type = "surface",
z = z_mat+2,
surfacecolor=surface_data,
colorscale = list(list(0, 1), list("yellow", "green"))) %>%
add_trace(type = "surface",
z = z_mat+1,
surfacecolor=surface_data,
colorscale = list(list(0, 1), list("blue", "purple")))

Does not render fine:
plot_ly(df, x=~x, y=~y) %>%
add_trace(type="surface",
z=z_mat,
surfacecolor=surface_data,
opacityscale=list(list(0, 1), list(1, 1)),
colorscale=list(list(0, 1), list("red", "orange"))) %>%
add_trace(type = "surface",
z = z_mat+1,
surfacecolor=surface_data,
opacityscale=list(list(0, 1), list(1, 1)),
colorscale = list(list(0, 1), list("yellow", "green"))) %>%
add_trace(type = "surface",
z = z_mat+2,
surfacecolor=surface_data,
opacityscale=list(list(0, 1), list(1, 1)),
colorscale = list(list(0, 1), list("blue", "purple")))

I've had a little trouble figuring out exactly how to best pass the opacityscale argument in R but I believe these settings should disable the opacity completely by setting every value between 0 and 1 to an opacity between 1 and 1 (i.e., always 1 and fully opaque).
Additionally, the surface that renders on "top" is the one that's added last in the piping order. If we alter the above code a little bit to render the purple/blue surface before the yellow/green one, we get some more interesting renders:
plot_ly(df, x=~x, y=~y) %>%
add_trace(type="surface",
z=z_mat,
surfacecolor=surface_data,
opacityscale=list(list(0, 1), list(1, 1)),
colorscale=list(list(0, 1), list("red", "orange"))) %>%
add_trace(type = "surface",
z = z_mat+2,
surfacecolor=surface_data,
opacityscale=list(list(0, 1), list(1, 1)),
colorscale = list(list(0, 1), list("blue", "purple"))) %>%
add_trace(type = "surface",
z = z_mat+1,
surfacecolor=surface_data,
opacityscale=list(list(0, 1), list(1, 1)),
colorscale = list(list(0, 1), list("yellow", "green")))


コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
提供された R の例で plot_ly()、add_trace()、surface トレース、opacityscale を使用して問題を再現し、その後、opacityscale がある場合とない場合のレンダリングを比較します。issue 4331 で参照されている plotly.js の実装を追って動作を確認します。opacityscale が存在する場合に、surface の順序がトレースの追加順ではなく深度に従えば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- javascript, r
- 領域
- data-visualization
- issue の種類
- バグ
- 難易度
- 4/5
- 見積もり時間
- 3〜5日
- 活発さ
- 停滞
- 明瞭さ
- おおむね明確
- 初心者へのやさしさ
- 30/100