plotly / plotly/plotly.R

Using opacityscale with surface results in ordering by addition order, not depth

Abierto
#1,781 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
R
Estrellas
2.7k
Forks
641
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hi, been using plotly with R for a while now and really loving it - thanks for assembling such a phenomenal program! I'd like to report a bug found while plotting multiple surface objects, which causes them to layer in the order they're added (using %>%) rather than the "depth" at which they should really render in the figure. See below for code and examples.

The "opacityscale" function is a new one from the dev branch (and I don't think problems with it have been reported on here before) so this question may be a better fit for https://github.com/plotly/plotly.js instead, where there's a bit more discussion about it and the original implementation, but I don't know JavaScript and can't provide a reprex there.

This is great:

image

This is not great (same figure rotated to look from below):

image

It only seems to show up if the opacityscale parameter is added, even if the opacity is set to 1 for all values.

Renders fine:
# devtools::install_github("ropensci/plotly")
library(plotly)
df <- data.frame(x=1:10, y=1:10)
surface_data <- matrix(1:100, nrow=10, ncol=10)
z_mat <- matrix(0, nrow = 10, ncol = 10)

plot_ly(df, x=~x, y=~y) %>%
  add_trace(type="surface",
            z=z_mat,
            surfacecolor=surface_data,
            colorscale=list(list(0, 1), list("red", "orange"))) %>%
  add_trace(type = "surface",
            z = z_mat+2,
            surfacecolor=surface_data,
            colorscale = list(list(0, 1), list("yellow", "green"))) %>%
  add_trace(type = "surface",
            z = z_mat+1,
            surfacecolor=surface_data,
            colorscale = list(list(0, 1), list("blue", "purple"))) 

image

Does not render fine:
plot_ly(df, x=~x, y=~y) %>%
  add_trace(type="surface",
            z=z_mat,
            surfacecolor=surface_data,
            opacityscale=list(list(0, 1), list(1, 1)),
            colorscale=list(list(0, 1), list("red", "orange"))) %>%
  add_trace(type = "surface",
            z = z_mat+1,
            surfacecolor=surface_data,
            opacityscale=list(list(0, 1), list(1, 1)),
            colorscale = list(list(0, 1), list("yellow", "green"))) %>%
  add_trace(type = "surface",
            z = z_mat+2,
            surfacecolor=surface_data,
            opacityscale=list(list(0, 1), list(1, 1)),
            colorscale = list(list(0, 1), list("blue", "purple")))

image

I've had a little trouble figuring out exactly how to best pass the opacityscale argument in R but I believe these settings should disable the opacity completely by setting every value between 0 and 1 to an opacity between 1 and 1 (i.e., always 1 and fully opaque).

Additionally, the surface that renders on "top" is the one that's added last in the piping order. If we alter the above code a little bit to render the purple/blue surface before the yellow/green one, we get some more interesting renders:

plot_ly(df, x=~x, y=~y) %>%
  add_trace(type="surface",
            z=z_mat,
            surfacecolor=surface_data,
            opacityscale=list(list(0, 1), list(1, 1)),
            colorscale=list(list(0, 1), list("red", "orange"))) %>%
  add_trace(type = "surface",
            z = z_mat+2,
            surfacecolor=surface_data,
            opacityscale=list(list(0, 1), list(1, 1)),
            colorscale = list(list(0, 1), list("blue", "purple"))) %>%
  add_trace(type = "surface",
            z = z_mat+1,
            surfacecolor=surface_data,
            opacityscale=list(list(0, 1), list(1, 1)),
            colorscale = list(list(0, 1), list("yellow", "green")))

image

image

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Reproduce el problema con los ejemplos de R proporcionados usando plot_ly(), add_trace(), trazas surface y opacityscale; después, compara el renderizado con y sin opacityscale. Sigue el comportamiento a través de la implementación de plotly.js referenciada por el issue 4331; se considera completado cuando el orden de las superficies sigue la profundidad en lugar del orden de adición de las trazas cuando está presente opacityscale.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript, r
Área
data-visualization
Tipo de issue
Error
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
30/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.