Consistent support for NTFS streams
- Ngôn ngữ chính
- C
- Star
- 40.4k
- Fork
- 8.2k
- Merge trung bình
- 2 ngày 13 giờ
- Pull request đã merge (30 ngày)
- 96
Mô tả
Description
The following code:
<?php
$filename = __DIR__ . "/ntfs.txt:foo";
var_dump(file_put_contents($filename, "bar"));
var_dump(file_get_contents($filename));
var_dump(file_exists($filename));
var_dump(realpath($filename));
var_dump(@stat($filename) !== false);
var_dump(basename($filename));
var_dump(file_exists(basename($filename)));
Resulted in this output for NTS builds:
int(3)
string(3) "bar"
bool(true)
bool(false)
bool(true)
string(12) "ntfs.txt:foo"
bool(false)
Resulted in this output for ZTS builds:
int(3)
string(3) "bar"
bool(false)
bool(false)
bool(false)
string(12) "ntfs.txt:foo"
bool(false)
As shown, the support for NTFS streams is totally inconsistent. Reading and writing such streams is supported, but file_exists() and stat() behave differently for NTS and ZTS builds (and even differently for NTS streams depending on whether an absolute or relative path is given). realpath() always fails.
Furthermore, pathinfo() and friends report the stream name as part of the filename, usually even as part of the file extension.
This (dangerous) inconsistency should be resolved one way or another. It might be best to completely remove support for NTFS streams for plain files, mostly to be consistent with other systems, and to avoid confusion for userland developers. A simple solution would be to "reject" such filenames, i.e. report permission denied when trying to access them. If we do this, pathinfo() and friends can likely stay as is.
If support for NTFS streams is desireable, we could introduce a new stream wrapper (say ntfs://) which would make NTFS stream access explicit.
PHP Version
all supported versions
Operating System
Windows
Hướng dẫn đóng góp
Bắt đầu từ đâu
- Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
- Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
- Fork repository và làm thay đổi trên một nhánh.
- Mở pull request có tham chiếu số hiệu của issue.
Đánh giá
Issue này chưa được đánh giá.