php / php/php-src

Consistent support for NTFS streams

Abierto
#9,230 0 comentarios 3 reacciones 1 asignado Ver en GitHub

@cmb69 ya está trabajando en esto.

Desde el 2/8/2022.

  • #9231 de @cmb69 — abierto
Category: Streams Feature OS: Windows Status: Needs Triage
Lenguaje dominante
C
Estrellas
40.4k
Forks
8.2k
Merge medio
2 d 13 h
PR fusionados (30 d)
96

Descripción

Description

The following code:

<?php
$filename = __DIR__ . "/ntfs.txt:foo";
var_dump(file_put_contents($filename, "bar"));
var_dump(file_get_contents($filename));
var_dump(file_exists($filename));
var_dump(realpath($filename));
var_dump(@stat($filename) !== false);
var_dump(basename($filename));
var_dump(file_exists(basename($filename)));

Resulted in this output for NTS builds:

int(3)
string(3) "bar"
bool(true)
bool(false)
bool(true)
string(12) "ntfs.txt:foo"
bool(false)

Resulted in this output for ZTS builds:

int(3)
string(3) "bar"
bool(false)
bool(false)
bool(false)
string(12) "ntfs.txt:foo"
bool(false)

As shown, the support for NTFS streams is totally inconsistent. Reading and writing such streams is supported, but file_exists() and stat() behave differently for NTS and ZTS builds (and even differently for NTS streams depending on whether an absolute or relative path is given). realpath() always fails.

Furthermore, pathinfo() and friends report the stream name as part of the filename, usually even as part of the file extension.

This (dangerous) inconsistency should be resolved one way or another. It might be best to completely remove support for NTFS streams for plain files, mostly to be consistent with other systems, and to avoid confusion for userland developers. A simple solution would be to "reject" such filenames, i.e. report permission denied when trying to access them. If we do this, pathinfo() and friends can likely stay as is.

If support for NTFS streams is desireable, we could introduce a new stream wrapper (say ntfs://) which would make NTFS stream access explicit.

PHP Version

all supported versions

Operating System

Windows

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.