Observer API: Correlated observer callbacks for a single invocation
Nessuno ha ancora preso questa issue.
- Lingua principale
- C
- Stelle
- 40.4k
- Fork
- 8.1k
- Merge medio
- 2g 13h
- PR unite (30g)
- 96
Descrizione
Description
Note:
I’ve already asked and explained part of this in another issue , but this is a broader feature request with example use cases.
Brief:
Observer API replacing zend_execute_ex hook provides notable benefits and one caveat (as it seems to me): there is no stable, per-invocation identifier that can be seen consistently across all observer callbacks.
Observer API callbacks are much like event handlers fired at the certain point of the lifecycle of an invocation, but they do not provide a means of identification of the invocation.
By being able to identify the invocation, information gathered in different events can be easily linked together for a meaningful “observation”.
Request:
- Adding a temporary to
zend_execute_data(likeop_array.reserved[]but per invocation) to be used for identification as developer sees fit - Passing
zend_execute_data(or the temporary at least) to other callbacks likezend_observer_error_cb
Use case examples:
- Associating runtime metrics like
start time,end time,return value,exceptionstogether without having to retain them in memory until all infos are gathered. - Associating infos gathered by means other than Observer API (e.g. hooking specific
PDOfunctions, replacing otherzif_handlerhandlers) with infos from callbacks.
It’s true that some of the infos named in 1st example can be easily linked together by a simple stack structure or HashTable (as pointed out in the above linked issue) but some others require more complex rules AFAICT and unnecessary bookkeeping.
zend_execute_data is already per-invocation, so I think it is cleaner and more straightforward to use that instead of each extension building and maintaining its own mapping.
P.S.: Please forgive me if there’s anything wrong with my thinking or writing; I’m not that experienced.
Cc: @bwoebi @ndossche
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia leggendo gli entry point della Observer API menzionati nell’issue: zend_execute_ex, zend_observer_error_cb e zend_execute_data, insieme all’uso di op_array.reserved[] e zif_handler. Confronta la discussione correlata nell’issue 20336. Il lavoro è completato quando il design della correlazione delle invocazioni e i requisiti relativi ai dati del callback sono concordati e implementati con una copertura adeguata.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- c, php
- Ambito
- backend-api-design, compilers
- Tipo di issue
- Funzionalità
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Stato di attività
- Ferma
- Chiarezza
- Da chiarire
- Idoneità per principianti
- 25/100