Observer API: Correlated observer callbacks for a single invocation
Personne n'a encore pris cette issue.
- Langage dominant
- C
- Étoiles
- 40.4k
- Forks
- 8.2k
- Merge moyen
- 2 j 13 h
- PR mergées (30 j)
- 96
Description
Description
Note:
I’ve already asked and explained part of this in another issue , but this is a broader feature request with example use cases.
Brief:
Observer API replacing zend_execute_ex hook provides notable benefits and one caveat (as it seems to me): there is no stable, per-invocation identifier that can be seen consistently across all observer callbacks.
Observer API callbacks are much like event handlers fired at the certain point of the lifecycle of an invocation, but they do not provide a means of identification of the invocation.
By being able to identify the invocation, information gathered in different events can be easily linked together for a meaningful “observation”.
Request:
- Adding a temporary to
zend_execute_data(likeop_array.reserved[]but per invocation) to be used for identification as developer sees fit - Passing
zend_execute_data(or the temporary at least) to other callbacks likezend_observer_error_cb
Use case examples:
- Associating runtime metrics like
start time,end time,return value,exceptionstogether without having to retain them in memory until all infos are gathered. - Associating infos gathered by means other than Observer API (e.g. hooking specific
PDOfunctions, replacing otherzif_handlerhandlers) with infos from callbacks.
It’s true that some of the infos named in 1st example can be easily linked together by a simple stack structure or HashTable (as pointed out in the above linked issue) but some others require more complex rules AFAICT and unnecessary bookkeeping.
zend_execute_data is already per-invocation, so I think it is cleaner and more straightforward to use that instead of each extension building and maintaining its own mapping.
P.S.: Please forgive me if there’s anything wrong with my thinking or writing; I’m not that experienced.
Cc: @bwoebi @ndossche
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par lire les points d’entrée de l’Observer API mentionnés dans l’issue : zend_execute_ex, zend_observer_error_cb et zend_execute_data, ainsi que l’utilisation de op_array.reserved[] et de zif_handler. Comparez avec la discussion associée dans l’issue 20336. Le travail est terminé lorsque la conception de la corrélation des invocations et les exigences relatives aux données du callback sont convenues et implémentées avec une couverture appropriée.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- c, php
- Domaine
- backend-api-design, compilers
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100