Observer API: Correlated observer callbacks for a single invocation
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- C
- Estrellas
- 40.4k
- Forks
- 8.2k
- Merge medio
- 2 d 15 h
- PR fusionados (30 d)
- 103
Descripción
Description
Note:
I’ve already asked and explained part of this in another issue , but this is a broader feature request with example use cases.
Brief:
Observer API replacing zend_execute_ex hook provides notable benefits and one caveat (as it seems to me): there is no stable, per-invocation identifier that can be seen consistently across all observer callbacks.
Observer API callbacks are much like event handlers fired at the certain point of the lifecycle of an invocation, but they do not provide a means of identification of the invocation.
By being able to identify the invocation, information gathered in different events can be easily linked together for a meaningful “observation”.
Request:
- Adding a temporary to
zend_execute_data(likeop_array.reserved[]but per invocation) to be used for identification as developer sees fit - Passing
zend_execute_data(or the temporary at least) to other callbacks likezend_observer_error_cb
Use case examples:
- Associating runtime metrics like
start time,end time,return value,exceptionstogether without having to retain them in memory until all infos are gathered. - Associating infos gathered by means other than Observer API (e.g. hooking specific
PDOfunctions, replacing otherzif_handlerhandlers) with infos from callbacks.
It’s true that some of the infos named in 1st example can be easily linked together by a simple stack structure or HashTable (as pointed out in the above linked issue) but some others require more complex rules AFAICT and unnecessary bookkeeping.
zend_execute_data is already per-invocation, so I think it is cleaner and more straightforward to use that instead of each extension building and maintaining its own mapping.
P.S.: Please forgive me if there’s anything wrong with my thinking or writing; I’m not that experienced.
Cc: @bwoebi @ndossche
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza leyendo los puntos de entrada de la Observer API mencionados en el issue: zend_execute_ex, zend_observer_error_cb y zend_execute_data, junto con el uso de op_array.reserved[] y zif_handler. Compara la discusión relacionada en el issue 20336. Se considera terminado cuando el diseño de correlación de invocaciones y los requisitos de datos del callback estén acordados e implementados con una cobertura adecuada.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- c, php
- Área
- backend-api-design, compilers
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100