stream_select checking of other streams when read buffered stream present
还没有人认领这个 Issue。
- 主要语言
- C
- 星标
- 40.4k
- 派生
- 8.2k
- 平均合并
- 2 天 13 小时
- 30 天内合并 PR
- 96
描述
Description
This is a result of analysis of the bug #75584 which points out a case where other supplied streams are not checked for read and write if there is a stream that has got buffered data. It means that only streams with buffered data are reported as changed. It is not necessarily a bug as the all data gets eventually processed but the behavior is certainly not optimal and should be optimized.
The optimization can be done by still checking (using select with 0 timeout) of the streams (fds) for write, read without buffered data and exceptional ones when a stream with buffered data is present. The buffered stream(s) would be removed from the checked set passed to select and automatically added to the returned set. In such way only the subset of descriptors would be checked with immediate return to verify if they are ready.
To give an example, following streams are defined
$w1- write stream ready for writing data$w2- write stream not ready for writing data$r1- read stream with buffered data available$r2- read stream without buffered data but data to be read$r3- read stream without buffered data and no data to be read$e1- stream with arrived exceptional data
and stream_select is executed as:
$read = [$r1, $r2, $r3];
$write = [$w1, $w2];
$except = [$e1];
stream_select($read, $write, $except, 1);
It will currently set $read array to [$r1] and $write and $except will be empty even though data is available in them. Only until the full buffer is read other streams would show in the arrays.
The optimization would change the behavior and instead of immediately returning after the setting $read with a buffered stream, it would also check the rest of the streams. It means it would basically do following check:
$read = [$r2, $r3];
$write = [$w1, $w2];
$except = [$e1];
stream_select($read, $write, $except, 0);
The result would be then merged and would be like following in this case:
$read = [$r1, $r2];
$write = [$w1];
$except = [$e1];
It should be noted that this approach might result in more syscalls but that seems like something that users should expect as they expect all the descriptors to be checked when calling stream_select.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 PHP 源码中的 stream_select 入口点开始,使用带缓冲、可读、可写和异常流复现该示例。跟踪带缓冲流如何影响描述符检查,然后验证所有就绪描述符会一并返回,同时保持所请求的超时行为。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- c, php
- 领域
- networking
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100