stream_select checking of other streams when read buffered stream present
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- C
- Estrellas
- 40.4k
- Forks
- 8.2k
- Merge medio
- 2 d 13 h
- PR fusionados (30 d)
- 96
Descripción
Description
This is a result of analysis of the bug #75584 which points out a case where other supplied streams are not checked for read and write if there is a stream that has got buffered data. It means that only streams with buffered data are reported as changed. It is not necessarily a bug as the all data gets eventually processed but the behavior is certainly not optimal and should be optimized.
The optimization can be done by still checking (using select with 0 timeout) of the streams (fds) for write, read without buffered data and exceptional ones when a stream with buffered data is present. The buffered stream(s) would be removed from the checked set passed to select and automatically added to the returned set. In such way only the subset of descriptors would be checked with immediate return to verify if they are ready.
To give an example, following streams are defined
$w1- write stream ready for writing data$w2- write stream not ready for writing data$r1- read stream with buffered data available$r2- read stream without buffered data but data to be read$r3- read stream without buffered data and no data to be read$e1- stream with arrived exceptional data
and stream_select is executed as:
$read = [$r1, $r2, $r3];
$write = [$w1, $w2];
$except = [$e1];
stream_select($read, $write, $except, 1);
It will currently set $read array to [$r1] and $write and $except will be empty even though data is available in them. Only until the full buffer is read other streams would show in the arrays.
The optimization would change the behavior and instead of immediately returning after the setting $read with a buffered stream, it would also check the rest of the streams. It means it would basically do following check:
$read = [$r2, $r3];
$write = [$w1, $w2];
$except = [$e1];
stream_select($read, $write, $except, 0);
The result would be then merged and would be like following in this case:
$read = [$r1, $r2];
$write = [$w1];
$except = [$e1];
It should be noted that this approach might result in more syscalls but that seems like something that users should expect as they expect all the descriptors to be checked when calling stream_select.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza en el punto de entrada stream_select del código fuente de PHP y reproduce el ejemplo con flujos con búfer, legibles, escribibles y excepcionales. Traza cómo el flujo con búfer afecta a las comprobaciones de los descriptores y, después, verifica que todos los descriptores listos se devuelvan juntos, preservando al mismo tiempo el comportamiento del tiempo de espera solicitado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- c, php
- Área
- networking
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 45/100