php / php/php-src

stream_select checking of other streams when read buffered stream present

Aperta
#10,177 2 commenti 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Category: Streams Feature
Lingua principale
C
Stelle
40.4k
Fork
8.1k
Merge medio
2g 13h
PR unite (30g)
96

Descrizione

Description

This is a result of analysis of the bug #75584 which points out a case where other supplied streams are not checked for read and write if there is a stream that has got buffered data. It means that only streams with buffered data are reported as changed. It is not necessarily a bug as the all data gets eventually processed but the behavior is certainly not optimal and should be optimized.

The optimization can be done by still checking (using select with 0 timeout) of the streams (fds) for write, read without buffered data and exceptional ones when a stream with buffered data is present. The buffered stream(s) would be removed from the checked set passed to select and automatically added to the returned set. In such way only the subset of descriptors would be checked with immediate return to verify if they are ready.

To give an example, following streams are defined

  • $w1 - write stream ready for writing data
  • $w2 - write stream not ready for writing data
  • $r1 - read stream with buffered data available
  • $r2 - read stream without buffered data but data to be read
  • $r3 - read stream without buffered data and no data to be read
  • $e1 - stream with arrived exceptional data

and stream_select is executed as:

$read = [$r1, $r2, $r3];
$write = [$w1, $w2];
$except = [$e1];
stream_select($read, $write, $except, 1);

It will currently set $read array to [$r1] and $write and $except will be empty even though data is available in them. Only until the full buffer is read other streams would show in the arrays.

The optimization would change the behavior and instead of immediately returning after the setting $read with a buffered stream, it would also check the rest of the streams. It means it would basically do following check:

$read = [$r2, $r3];
$write = [$w1, $w2];
$except = [$e1];
stream_select($read, $write, $except, 0);

The result would be then merged and would be like following in this case:

$read = [$r1, $r2];
$write = [$w1];
$except = [$e1];

It should be noted that this approach might result in more syscalls but that seems like something that users should expect as they expect all the descriptors to be checked when calling stream_select.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia dal punto di ingresso stream_select nel codice sorgente di PHP e riproduci l'esempio con flussi bufferizzati, leggibili, scrivibili ed eccezionali. Traccia il modo in cui il flusso bufferizzato influisce sui controlli dei descrittori, quindi verifica che tutti i descrittori pronti vengano restituiti insieme, preservando al contempo il comportamento del timeout richiesto.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
c, php
Ambito
networking
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.