socket.destroySoon causes two EventEmitter memory leaks when repetitively using it on a socket that is trying to connect
未关闭
还没有人认领这个 Issue。
- 主要语言
- JavaScript
- 星标
- 122k
- 派生
- 37.4k
- 平均合并
- 4 天 3 小时
- 30 天内合并 PR
- 272
描述
Version
v22.11.0
Platform
Darwin xxx.local 24.4.0 Darwin Kernel Version 24.4.0: Fri Apr 11 18:32:43 PDT 2025; root:xnu-11417.101.15~117/RELEASE_ARM64_T8103 arm64
Subsystem
net
What steps will reproduce the bug?
const { Socket } = require('node:net');
const socket = new Socket();
socket.on('error', (err) => {
console.log(`error: ${err.code}`);
});
socket.on('connect', () => {
console.log('connected');
});
socket.on('close', () => {
console.log('closed');
});
setInterval(() => {
socket.connect({ host: 'google.com', port: 5000 });
setTimeout(() => {
socket.destroySoon();
}, 5);
}, 100);
How often does it reproduce? Is there a required condition?
It reproduces always. Port 5000 is chosen as it times out.
What is the expected behavior? Why is that the expected behavior?
Seeing an infinite stream of
error: ECANCELED
closed
log lines
What do you see instead?
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
(node:46138) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 finish listeners added to [Socket]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
at genericNodeError (node:internal/errors:983:15)
at wrappedFn (node:internal/errors:537:14)
at _addListener (node:events:592:17)
at Socket.addListener (node:events:610:10)
at Readable.on (node:internal/streams/readable:1128:35)
at Socket.once (node:events:654:8)
at Socket.destroySoon (node:net:795:10)
at Timeout._onTimeout (/Users/robeverhardt/Downloads/test.js:17:12)
at listOnTimeout (node:internal/timers:594:17)
at process.processTimers (node:internal/timers:529:7)
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
(node:46138) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 connect listeners added to [Socket]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
at genericNodeError (node:internal/errors:983:15)
at wrappedFn (node:internal/errors:537:14)
at _addListener (node:events:592:17)
at Socket.addListener (node:events:610:10)
at Readable.on (node:internal/streams/readable:1128:35)
at Socket.once (node:events:654:8)
at Socket._final (node:net:525:17)
at prefinish (node:internal/streams/writable:916:14)
at finishMaybe (node:internal/streams/writable:930:5)
at Writable.end (node:internal/streams/writable:845:5)
Additional information
No response
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从复现脚本以及堆栈跟踪中列出的 node:net 入口点开始,尤其是 Socket.destroySoon 和 Socket._final。复现反复取消的连接,然后跟踪 finish 和 connect 监听器的添加与移除过程。当该场景不再产生 MaxListenersExceededWarning,并且包含针对该回归的覆盖测试时,即视为完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, node.js
- 领域
- networking
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 活跃
- 描述清晰度
- 描述清楚
- 新手友好度
- 52/100