socket.destroySoon causes two EventEmitter memory leaks when repetitively using it on a socket that is trying to connect
Offen
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- JavaScript
- Sterne
- 122k
- Forks
- 37.3k
- Ø Merge
- 4 T. 2 Std.
- Gemergte PRs (30 T.)
- 283
Beschreibung
Version
v22.11.0
Platform
Darwin xxx.local 24.4.0 Darwin Kernel Version 24.4.0: Fri Apr 11 18:32:43 PDT 2025; root:xnu-11417.101.15~117/RELEASE_ARM64_T8103 arm64
Subsystem
net
What steps will reproduce the bug?
const { Socket } = require('node:net');
const socket = new Socket();
socket.on('error', (err) => {
console.log(`error: ${err.code}`);
});
socket.on('connect', () => {
console.log('connected');
});
socket.on('close', () => {
console.log('closed');
});
setInterval(() => {
socket.connect({ host: 'google.com', port: 5000 });
setTimeout(() => {
socket.destroySoon();
}, 5);
}, 100);
How often does it reproduce? Is there a required condition?
It reproduces always. Port 5000 is chosen as it times out.
What is the expected behavior? Why is that the expected behavior?
Seeing an infinite stream of
error: ECANCELED
closed
log lines
What do you see instead?
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
(node:46138) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 finish listeners added to [Socket]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
at genericNodeError (node:internal/errors:983:15)
at wrappedFn (node:internal/errors:537:14)
at _addListener (node:events:592:17)
at Socket.addListener (node:events:610:10)
at Readable.on (node:internal/streams/readable:1128:35)
at Socket.once (node:events:654:8)
at Socket.destroySoon (node:net:795:10)
at Timeout._onTimeout (/Users/robeverhardt/Downloads/test.js:17:12)
at listOnTimeout (node:internal/timers:594:17)
at process.processTimers (node:internal/timers:529:7)
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
(node:46138) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 connect listeners added to [Socket]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
at genericNodeError (node:internal/errors:983:15)
at wrappedFn (node:internal/errors:537:14)
at _addListener (node:events:592:17)
at Socket.addListener (node:events:610:10)
at Readable.on (node:internal/streams/readable:1128:35)
at Socket.once (node:events:654:8)
at Socket._final (node:net:525:17)
at prefinish (node:internal/streams/writable:916:14)
at finishMaybe (node:internal/streams/writable:930:5)
at Writable.end (node:internal/streams/writable:845:5)
Additional information
No response
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit dem Reproduktionsskript und den in den Stacktraces genannten node:net-Einstiegspunkten, insbesondere Socket.destroySoon und Socket._final. Reproduziere die wiederholt abgebrochenen Verbindungen und verfolge anschließend, wie finish- und connect-Listener hinzugefügt und entfernt werden. Als abgeschlossen gilt die Aufgabe, wenn das Szenario keine MaxListenersExceededWarning mehr erzeugt und eine Abdeckung für die Regression vorhanden ist.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript, node.js
- Bereich
- networking
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Aktiv
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 52/100