socket.destroySoon causes two EventEmitter memory leaks when repetitively using it on a socket that is trying to connect
Abierto
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- JavaScript
- Estrellas
- 122k
- Forks
- 37.3k
- Merge medio
- 4 d 2 h
- PR fusionados (30 d)
- 283
Descripción
Version
v22.11.0
Platform
Darwin xxx.local 24.4.0 Darwin Kernel Version 24.4.0: Fri Apr 11 18:32:43 PDT 2025; root:xnu-11417.101.15~117/RELEASE_ARM64_T8103 arm64
Subsystem
net
What steps will reproduce the bug?
const { Socket } = require('node:net');
const socket = new Socket();
socket.on('error', (err) => {
console.log(`error: ${err.code}`);
});
socket.on('connect', () => {
console.log('connected');
});
socket.on('close', () => {
console.log('closed');
});
setInterval(() => {
socket.connect({ host: 'google.com', port: 5000 });
setTimeout(() => {
socket.destroySoon();
}, 5);
}, 100);
How often does it reproduce? Is there a required condition?
It reproduces always. Port 5000 is chosen as it times out.
What is the expected behavior? Why is that the expected behavior?
Seeing an infinite stream of
error: ECANCELED
closed
log lines
What do you see instead?
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
(node:46138) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 finish listeners added to [Socket]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
at genericNodeError (node:internal/errors:983:15)
at wrappedFn (node:internal/errors:537:14)
at _addListener (node:events:592:17)
at Socket.addListener (node:events:610:10)
at Readable.on (node:internal/streams/readable:1128:35)
at Socket.once (node:events:654:8)
at Socket.destroySoon (node:net:795:10)
at Timeout._onTimeout (/Users/robeverhardt/Downloads/test.js:17:12)
at listOnTimeout (node:internal/timers:594:17)
at process.processTimers (node:internal/timers:529:7)
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
error: ECANCELED
closed
(node:46138) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 connect listeners added to [Socket]. MaxListeners is 10. Use emitter.setMaxListeners() to increase limit
at genericNodeError (node:internal/errors:983:15)
at wrappedFn (node:internal/errors:537:14)
at _addListener (node:events:592:17)
at Socket.addListener (node:events:610:10)
at Readable.on (node:internal/streams/readable:1128:35)
at Socket.once (node:events:654:8)
at Socket._final (node:net:525:17)
at prefinish (node:internal/streams/writable:916:14)
at finishMaybe (node:internal/streams/writable:930:5)
at Writable.end (node:internal/streams/writable:845:5)
Additional information
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con el script de reproducción y los puntos de entrada de node:net indicados en los stack traces, especialmente Socket.destroySoon y Socket._final. Reproduce las conexiones canceladas repetidamente y, después, rastrea cómo se añaden y eliminan los listeners de finish y connect. Se considera terminado cuando el escenario ya no produce MaxListenersExceededWarning y existe cobertura para la regresión.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript, node.js
- Área
- networking
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Activo
- Claridad
- Bien especificado
- Aptitud para principiantes
- 52/100