`fsPromise.writeFile` should catch stream's error and reject the promise.

Version

22.16.0

Platform

All

Subsystem

No response

What steps will reproduce the bug?

Following code fails with an application crash.

import fsp from "node:fs/promises";
import { createReadStream } from "node:fs";

try {
    const s1 = createReadStream("not-existent");
    await fsp.writeFile("new-file.txt", s1);
} catch (error) {
    console.log(`Sorry file copy failed`);
}

Instead it should just say that an error has occurred and reject the promise.

How often does it reproduce? Is there a required condition?

Everytime

What is the expected behavior? Why is that the expected behavior?

The application should not crash and an error should be thrown.

What do you see instead?

Application Crashes.

Reproduction Repository

ackava/node-write-file-promise-fail

This repo contains docker container source code to reproduce error in container. On windows machine, delay causes app to crash but in container, slight delay of 1 ms causes crash.

Workaround

So far following code works correctly with slight time differences, and does not crash the app, promise is rejected correctly.

        const writable = createWriteStream(outputFilePath);
        return pipeline(inputStream, writable, { end: true });

Bắt đầu với các entry point fsPromise.writeFile và createReadStream được hiển thị trong bản tái hiện, sau đó so sánh cách xử lý lỗi của chúng với workaround dùng pipeline. Sử dụng repository tái hiện được liên kết để tái hiện sự cố crash và xác minh rằng khi thiếu tệp đầu vào, promise bị reject thay vì làm ứng dụng crash.