`fsPromise.writeFile` should catch stream's error and reject the promise.

Version

22.16.0

Platform

All

Subsystem

No response

What steps will reproduce the bug?

Following code fails with an application crash.

import fsp from "node:fs/promises";
import { createReadStream } from "node:fs";

try {
    const s1 = createReadStream("not-existent");
    await fsp.writeFile("new-file.txt", s1);
} catch (error) {
    console.log(`Sorry file copy failed`);
}

Instead it should just say that an error has occurred and reject the promise.

How often does it reproduce? Is there a required condition?

Everytime

What is the expected behavior? Why is that the expected behavior?

The application should not crash and an error should be thrown.

What do you see instead?

Application Crashes.

Reproduction Repository

ackava/node-write-file-promise-fail

This repo contains docker container source code to reproduce error in container. On windows machine, delay causes app to crash but in container, slight delay of 1 ms causes crash.

Workaround

So far following code works correctly with slight time differences, and does not crash the app, promise is rejected correctly.

        const writable = createWriteStream(outputFilePath);
        return pipeline(inputStream, writable, { end: true });

再現例に示されている fsPromise.writeFile と createReadStream のエントリーポイントから始め、次にそれらのエラーハンドリングを pipeline の回避策と比較してください。リンクされた再現用リポジトリを使ってクラッシュを再現し、入力ファイルが存在しない場合にアプリケーションがクラッシュするのではなく promise が拒否されることを確認してください。