nodeSolidServer / nodeSolidServer/node-solid-server

remove bootstrap dependency

未關閉
#1,867 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視

還沒有人認領這個 Issue。

主要語言
JavaScript
星號
1.8k
分支
308
PR 合併指標
30 天內沒有已合併 PR

描述

NSS only use bootstrap icons. We may use SolidOS icons
We use bootstrap@4 latest open source license. This version has a vulnerability

https://matrix.to/#/!wAfwwonbRnRLYejFOR:gitter.im/$xFAiECLG1apc87yny74sGTrW87sA0cI6UNvSl5ctVR4?via=gitter.im&via=matrix.org&via=chat.semantic.works

Wednesday
* Noel De Martin
I use icons like this https://icones.js.org/
* Noel De Martin
So basically I look for the icons I want to use in that website, and then in my code I just write the <i- element (I don't have to import any library or anything), then when the app is built the SVGs are auto-replaced :)
Here's an example of using that in Umai: https://github.com/NoelDeMartin/umai/blob/a0d2887e8f70d93ee6f3b3d33b39452cea5874c9/src/components/AppHeaderUserMenu.vue#L18
and regarding colors, they use fillCurrent by default, so they'll have the same color as the text. It can also be overriden by setting the text color with CSS
* Tim Berners-Lee
Our icons are mostly from https://thenounproject.com/
* Noel De Martin
I see, it seems like most of them are plain SVGs (not part of any icon set). You can also add custom SVGs using this, for example I have a few here: https://github.com/NoelDeMartin/umai/tree/main/src/assets/icons
I'll see if I can integrate something like this in SolidOS :). It's also better to use icons from an icon set in order to keep a consistent visual identity, grabbing random SVGs from websites can create some UI inconsistencies
* Timea
this is because Sharon downloaded them from the new design.
I could ask the designer if they use some icon Library....
at the top of the meeting minutes find a link to a ticket where our current designs are. it's all figma.
* Tim Berners-Lee
I don't see why NounProject is not considered an icon set .. it has too many alternatives?
* Tim Berners-Lee
The icons are in https://github.com/SolidOS/solid-ui/tree/main/src/icons ... so we use consistent icons across SolidOS and also apps.
* Noel De Martin
* Tim Berners-Lee
I don't see why NounProject is not considered an icon set .. it has too many alternatives?
yeah, it's not an icon set, it's just a marketplace where anyone can upload their SVGs. Icon sets usually have a consistent style, etc. It's like using a font family, you can use as many font families as you want in a website, but it's usually better to choose a couple that look well together.
* Timea
it's just about the designers choice and the look of them.i can see what they say.

貢獻指南

開啟貢獻指南

從這裡開始

  1. 先讀完整個 Issue,再讀專案的貢獻指南。
  2. 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
  3. Fork 儲存庫,在一個分支上完成修改。
  4. 送出 Pull Request,並在描述裡引用這個 Issue 編號。

研究方向

在儲存庫中搜尋 bootstrap@4 相依性及其圖示使用位置,然後檢視 SolidOS 圖示目錄和連結的圖示討論,以尋找可能的替代方案。完成的標準是移除 Bootstrap 且不留下圖示參照,並且替代方案已達成共識並經過驗證。

由索引模型根據 Issue 內容生成。

評估

技術堆疊
bootstrap, javascript
領域
frontend
Issue 類型
重構
難度
4/5
預估耗時
3-5 天
活躍度
冷清
描述清晰度
需要釐清
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。